[6.8.2] Inconsistency in disk temperature threshold checking

A couple of times in the last few months I've been surprised to receive a weekly array health report e-mail telling me I have a drive overheating, when I've not previously received an independent notification for that drive being too hot.

I believe I've tracked this down to an inconsistency in how the two scripts are determining if a drive is too hot.

In /usr/local/emhttp/plugins/dynamix/scripts/statuscheck, the relevant check is:

if ($temp>=$max) {
    $fail = ' (disk is overheated';
    $error0++;
} elseif ($temp>=$hot) {
    $fail = ' (disk is hot';
    $error1++;
} else {
    $fail = '';
}

Whereas in /usr/local/emhttp/plugins/dynamix/scripts/monitor, the code is:

$warn = exceed($temp,$max,$top) ? 'alert' : (exceed($temp,$hot,$top) ? 'warning' : '');

Which uses the 'exceed' helper function, defined in /usr/local/emhttp//webGui/include/Wrappers.php:

function exceed($value, $limit, $top=100) {
    return ($value>$limit && $limit>0 && $value<=$top);
}

As can be seen, the script that runs the weekly health check is checking if the disk temperature is >= than the threshold temperature, whereas the script that triggers the independent notifications is checking if the disk temperature > than the threshold temperature.

This means that if your warning threshold is set to, say, 40 degrees, and you have a disk that's running at 40 degrees, the health report will mark the disk as too hot, but there will be no independent notification until the disk reaches 41 degrees.

Apologies for not testing this on 6.8.3, but I have checked the release notes and can't see any mention of this being fixed.