Permissions on files installed by plugins

[ljm42]

Hey plugin authors! I am trying to prevent a class of errors related to ownership and permissions on files/dirs installed by plugins.

 

We want to make sure that all files/dirs are owned by root:root and have perms of 755 or 644. This applies to files installed in the operating system, not user files you place on the flash or array.

 

Unraid itself does not yet enforce these rules, but I'd like to get there.

 

I've written a small script that detects problems, you can see it here:
  https://gist.github.com/ljm42/d612bcfbc071d854baba53c482fd64e4

 

To run it on your system and detect issues with the plugins you have installed:

• cd /tmp
• wget https://gist.github.com/ljm42/d612bcfbc071d854baba53c482fd64e4/raw -O plgcheck
• bash plgcheck

 

It will run through the txz files on your flash drive and flag any ownership issues or permission issues.

 

Please update your plugin's txz files so they are not flagged by this test. Or let me know if you think it is flagging something unnecessarily.

 

Thanks!

 

p.s. please don't feel personally attacked by this, my plugin fails this test currently too 

[Squid]

8 minutes ago, ljm42 said:

please don't feel personally attacked by this,

Too late  

[ljm42]

LOL you know I was thinking of you when I wrote that  

[ljm42]

Thanks @dlandon and @Squidfor updating your plugins to pass these tests!

[dlandon]

4 hours ago, Squid said:

Too late  

Yea, I got busted by the permissions cop too.

[dlandon]

On 3/10/2021 at 2:12 PM, ljm42 said:

 

I've written a small script that detects problems, you can see it here:

You need to modify your script to also include .tgz.  I use a zipped file that I unzip into the proper plugin location.  I don't create a package.