Hi Team, I just installed the patch and mover stopped moving files now. am I expected to uninstall mover tuner with this patchj?

39 minutes ago, takkkkkkk said:

Hi Team, I just installed the patch and mover stopped moving files now. am I expected to uninstall mover tuner with this patchj?

With mover tuning installed, installing the patch from the GUI will fail and a notice will display advising to reboot to apply the patches.

 

Mover tuning actually replaces the mover script (why this patch fails), but there seems to be a fair amount of issues with Mover Tuning as of late even before this patch came into existence.   Best to ask over in its support thread

11 hours ago, Cexitime said:

Automatic install who on earth thought this was ok?, If I wanted that I would just run windows.

 

Will have to remove this and not install in future, hopefully it wont be automatically pushed on us.

Changes due next week regarding auto installations.  This feature set got side tracked due to the unforeseen issues regarding what Mover Tuning is doing.

 

We highly recommend that this patch plugin be installed and the patches being issued are applied

11 hours ago, smdion said:

Thanks for the response.  Is the patch version number that is inside the patch plugin consistent across major/minor versions?  Just trying to think of a human way to talk through stuff without listing out every fix.

 

The patches being released for 7.0.0 will never be applied to another version so there is nothing for them to be consistent with.

 

12 hours ago, smdion said:

My sysadmin brain just likes to go "okay, I'm on the current version cuz I see I'm 7.0.0 and patch 1.0.0.", instead of comparing a list of bug fixes.

 

Yes this is a valid statement. If additional patches are released for 7.0.0 the patch number will increment. We can look at having the plugin put that patch number in the syslog

Why do these patches require a reboot? At that point why not just release a patchfix release and increment the versioning?

1 minute ago, DiscoverIt said:

Why do these patches require a reboot? At that point why not just release a patchfix release and increment the versioning?

The patches do not require a reboot to apply fully.

 

If you've gotten the message saying that a reboot is required it is because you've got Mover Tuning Plugin installed.  It replaces one of the files that are being patched.  That plugin in its course of action does wind up calling the original script that we are patching. 

 

Because we are patching that file, the only way to install the patch is to reboot.  Any future patches (if released) won't require a reboot.

1 hour ago, Squid said:

If you've gotten the message saying that a reboot is required it is because you've got Mover Tuning Plugin installed.  It replaces one of the files that are being patched.  That plugin in its course of action does wind up calling the original script that we are patching. 

 

at least it should be removed if we remove the plugin then (patch plugin)

 

but even removing this plugin will still keep the "reboot required" banner up ... without any chance to close it.

 

so, yes, only cosmetic ... but annoying.

1 hour ago, Squid said:

The patches do not require a reboot to apply fully.

 

If you've gotten the message saying that a reboot is required it is because you've got Mover Tuning Plugin installed.  It replaces one of the files that are being patched.  That plugin in its course of action does wind up calling the original script that we are patching. 

 

Because we are patching that file, the only way to install the patch is to reboot.  Any future patches (if released) won't require a reboot.

 

I installed the plugin, rebooted and still the tool page says: "No new patches found! The following patches are already installed and will be reinstalled automatically when your server boots"

 

I do not have the Mover Tuning plugin installed and I did not have it have it when I installed the patch plugin. I had the Mover Tuning plugin earlier but uninstalled it a while ago.

 

So, should I reboot my server again or does the above text mean, that patching has been done and it will be done again every time I reboot?

Edited January 31, 20251 yr by Ruato

I just installed the update to the plugin and this line (see yellow arrow) caught my eye. It seems to be indicating that the instalation cannot proceed but immediately below that the message indicates a successful install. What gives? Is this just an error reporting bug?

1 hour ago, alturismo said:

but even removing this plugin will still keep the "reboot required" banner up ... without any chance to close it.

 

Because the patch would still fail to fully install on the second attempt, because it would try to patch the other files which have already been patched and then subsequently fail.

 

I can change how the reboot notification gets handled and make it dismissable

1 hour ago, Ruato said:

The following patches are already installed and will be reinstalled automatically when your server boots"

Did it list the patch and description?  

10 hours ago, Squid said:

We highly recommend that this patch plugin be installed and the patches being issued are applied

I'd highly recommend fixing the current patching process with proper testing before deployment instead of trying to push another update system on us so that now we have two systems in place that we have to test ourselves to see if anything is going to break.

 

No this is not being installed, recommend all you want.

Edited February 1, 20251 yr by Cexitime

7 hours ago, Squid said:

Because the patch would still fail to fully install on the second attempt, because it would try to patch the other files which have already been patched and then subsequently fail.

 

i was pointing to removing the patch plugin, still keeping the reboot required up ...

 

7 hours ago, Squid said:

I can change how the reboot notification gets handled and make it dismissable

yes please, like any other banners which can be closed ...

 

even on Win i can close this Window, Notification, ...  

I've just tried to let a patch install for the first time... and looks like the mover part of the patch failed:

 

Installing /boot/config/plugins/unraid.patch/7.0.0/20250128204439-pr271.patch...

patching file emhttp/plugins/dynamix.vm.manager/templates/Custom.form.php
patching file emhttp/plugins/dynamix/include/FileTree.php
patching file emhttp/plugins/dynamix/include/ShareList.php
patching file emhttp/plugins/dynamix/scripts/diagnostics
patching file sbin/mover
Hunk #1 FAILED at 72.
1 out of 1 hunk FAILED -- saving rejects to file sbin/mover.rej

Failed to install patch 20250128204439-pr271.patch Aborting

 

What should i do to resolve this?

 

I do have CA Mover Tuning plugin installed. Is that no longer compatible?

5 hours ago, DavidIrwin said:

I've just tried to let a patch install for the first time... and looks like the mover part of the patch failed:

 

Installing /boot/config/plugins/unraid.patch/7.0.0/20250128204439-pr271.patch...

patching file emhttp/plugins/dynamix.vm.manager/templates/Custom.form.php
patching file emhttp/plugins/dynamix/include/FileTree.php
patching file emhttp/plugins/dynamix/include/ShareList.php
patching file emhttp/plugins/dynamix/scripts/diagnostics
patching file sbin/mover
Hunk #1 FAILED at 72.
1 out of 1 hunk FAILED -- saving rejects to file sbin/mover.rej

Failed to install patch 20250128204439-pr271.patch Aborting

 

What should i do to resolve this?

 

I do have CA Mover Tuning plugin installed. Is that no longer compatible?

 

Just restart afterwards, and it should be all good. As far as I can tell, the tuner plugin is still working fine after the patch. 

Edited February 2, 20251 yr by eventorism

1 hour ago, eventorism said:

 

Just restart afterwards, and it should be all good. As far as I can tell, the tuner plugin is still working fine after the patch. 

That doesn’t seem to work (at least not for me). I’ve installed several times over the past few days, rebooted several times, uninstalled the mover tuning plugin and rebooted. The patch tool still shows that I have a patch to install and sends me email notifications for this. Hopefully this will get fixed shortly. Wouldn’t mind if it wasn’t for the emails.

4 minutes ago, wgstarks said:

That doesn’t seem to work (at least not for me). I’ve installed several times over the past few days, rebooted several times, uninstalled the mover tuning plugin and rebooted. The patch tool still shows that I have a patch to install and sends me email notifications for this. Hopefully this will get fixed shortly. Wouldn’t mind if it wasn’t for the emails.

 

Odd. It worked for me on the first try. I didn't uninstall/disable the tuning plugin prior to or after installing the patch. 

 

Hope there's a quick fix ASAP. 

 

Edited February 2, 20251 yr by eventorism

23 hours ago, wgstarks said:

That doesn’t seem to work (at least not for me). I’ve installed several times over the past few days, rebooted several times, uninstalled the mover tuning plugin and rebooted. The patch tool still shows that I have a patch to install and sends me email notifications for this. Hopefully this will get fixed shortly. Wouldn’t mind if it wasn’t for the emails.

 

Sorry for the trouble.  Please make sure you have at least version 2025.01.31a of the Patch plugin, this will detect that the patch failed due to a conflict with Mover Tuning and advice that you reboot. Upon reboot, the Patch plugin will be installed first, before any other plugins. This will avoid conflicts with other plugins.

 

If you have rebooted after installing the latest Patch plugin and continue to have issues, please post your diagnostics so we can review the logs.

On 1/31/2025 at 12:24 PM, blender50 said:

I just installed the update to the plugin and this line (see yellow arrow) caught my eye. It seems to be indicating that the instalation cannot proceed but immediately below that the message indicates a successful install. What gives? Is this just an error reporting bug?

Sorry for the confusion, this looks benign. Please upgrade to the latest release and confirm that when you go to Tools > Unraid Patch it says that the patches are installed

On 1/31/2025 at 10:35 PM, Squid said:

Did it list the patch and description?  

 

It is like the attached screen capture. Is that as it's supposed to be?

 

After installing the patch and after reboot I noticed this warning / error in the console output just before "unRAID Server OS version: ..." line:

 

/tmp/inline.sh: line 3: NOT_DELETE.plg: command not found

 

This has not been there before the patch was installed. Anybody else noticed this?

Edited February 3, 20251 yr by Ruato
Added a clarification that the line has not been there before the patch was installed.

I keep getting this error;

 

Quote

A patch failed to install, it is likely that a system file was already modified by a different plugin. Please reboot the system so the patch will be applied before other plugins are installed.

 

Any way I can patch without reseting my system (its a pain to reset)

 

Diagnostics attached 

homeunraid-diagnostics-20250205-1637.zip

You can uninstall the mover tuning plugin, reapply the patches, but then errors would result on all of the other files prompting the system to show the banner again to reboot to apply.

 

With regards to the patch for mover, I wouldn't fret about this immediately.  Reboot when its convenient.  Next revision of the patch plugin is going to have a ton of changes which is going to adjust the behaviour and address most of the concerns / suggestions people have voiced here

On 2/3/2025 at 5:43 PM, Ruato said:

It is like the attached screen capture. Is that as it's supposed to be?

 

Yes - It says "Already Installed"

On 2/3/2025 at 5:47 PM, Ruato said:

This has not been there before the patch was installed. Anybody else noticed this?

Thanks.  The message itself is harmless, and we're trying to figure out why it's showing up.