Squid Posted May 10, 2016 Author Share Posted May 10, 2016 My personal opinion, I think that the auto-update for this plugin (Fix Common Problems) should be a Warning not an Error, but it's not a big deal. With tonight's / tomorrows update I'll add it to the docker FAQ as its going to do some tests that CHBMB is bugging me to add for installed apps And the constant updates is why its an error - I know how I do software - small updates, update often rather than large updates, update rarely Quote Link to comment
ljm42 Posted May 10, 2016 Share Posted May 10, 2016 EDIT: As a meet half way type thing, what I'll do is instead of skipping the tests that can potentially spin up a drive is only run the test on the drive is unRaid thinks its spun up if you select that option. Thanks, that sounds perfect to me I wouldn't mind if it spun the drives up monthly or even weekly to do the full test, but right now I'm running it daily and would rather they not spin up. I suppose another option would be for me to run it less often Quote Link to comment
Squid Posted May 10, 2016 Author Share Posted May 10, 2016 EDIT: As a meet half way type thing, what I'll do is instead of skipping the tests that can potentially spin up a drive is only run the test on the drive is unRaid thinks its spun up if you select that option. Thanks, that sounds perfect to me I wouldn't mind if it spun the drives up monthly or even weekly to do the full test, but right now I'm running it daily and would rather they not spin up. I suppose another option would be for me to run it less often If you schedule it to run at the same time as the parity check, then at least it'll check the writes to every drive at that point. (It only writes a random file containing "TEST" (filename checked to make sure it doesn't conflict with a file already on the drive, and then reads it back and compares -> any discrepancy triggers an error, so it won't even be a noticeable delay in the parity check speeds (ie: it will maybe slow it down by a second or two) FYI, for simplicity sake, I only offer hourly, daily, weekly, monthly tests (and disabled) I don't want to get too complicated on the scheduling just so that its all kept nice and simply for users. But you can change the actual times its run by installing Dynamix Fixed Schedules Plugin which will then allow you to adjust the time this runs at. Quote Link to comment
wgstarks Posted May 11, 2016 Share Posted May 11, 2016 EDIT: As a meet half way type thing, what I'll do is instead of skipping the tests that can potentially spin up a drive is only run the test on the drive is unRaid thinks its spun up if you select that option. The default is to go ahead and run the test (spin up) all disks right? Just want to make sure it's not disabled just because I didn't correct the settings after an auto update. Quote Link to comment
Squid Posted May 11, 2016 Author Share Posted May 11, 2016 EDIT: As a meet half way type thing, what I'll do is instead of skipping the tests that can potentially spin up a drive is only run the test on the drive is unRaid thinks its spun up if you select that option. The default is to go ahead and run the test (spin up) all disks right? Just want to make sure it's not disabled just because I didn't correct the settings after an auto update. correct. On this plug (and CA for that matter) whenever I add a setting, I always make them default to whatever I think it should be if the user doesn't go in and change it. Quote Link to comment
JonathanM Posted May 11, 2016 Share Posted May 11, 2016 To install this plugin, either head over to the Apps tab and find the Find Common Problems plugin.That doesn't get any results. Searching for Fix Common Problems, oddly enough, works. Quote Link to comment
JonathanM Posted May 11, 2016 Share Posted May 11, 2016 What would you like to see or want me to check to fix the following discrepancy? Errors found in auto update. Quote Link to comment
Squid Posted May 11, 2016 Author Share Posted May 11, 2016 Make a change and then apply it. Known issue as posted in 3rd post. Needs an update to CA to fix Quote Link to comment
Squid Posted May 11, 2016 Author Share Posted May 11, 2016 To install this plugin, either head over to the Apps tab and find the Find Common Problems plugin.That doesn't get any results. Searching for Fix Common Problems, oddly enough, works. Only way that CA doesn't show an app in available apps is if its already installed (because at that point, its no longer available). Searching displays everything installed or not. Quote Link to comment
JonathanM Posted May 11, 2016 Share Posted May 11, 2016 Make a change and then apply it. Known issue as posted in 3rd post. Needs an update to CA to fix My bad. I assumed next day or so had already passed. You probably ought to adopt limetech's "Soon" every time you issue a forward looking statement. Quote Link to comment
Squid Posted May 11, 2016 Author Share Posted May 11, 2016 Make a change and then apply it. Known issue as posted in 3rd post. Needs an update to CA to fix My bad. I assumed next day or so had already passed. You probably ought to adopt limetech's "Soon" every time you issue a forward looking statement. lol I'll try and not take offense at that My "day or two" tends to always be within a day or two or three" Actually, that was tomorrow's job for CA Quote Link to comment
Squid Posted May 11, 2016 Author Share Posted May 11, 2016 So that tomorrow I can fix the bug in CA's autoupdate settings (only affect this program), and hopefully add in the dated appdata backups, - Ability to only run the write checks on disks already spun up - Checks against docker applications installed where the user has changed the Container Port (more of a problem on 6.1.x as 6.2 tries to hide the setting better, but still quite possible for a user to do this), and doing it will almost guarantee the app won't work (thanks CHBMB for being a PITA ) - Ability for user scripts to check for and add to the errors / warnings / other notes section of the plugin. Any script located within /boot/config/plugins/fix.common.problems/scripts/ (must be executable) will be automatically executed by this plugin whenever it runs. A sample script (sample.php) is provided with the php helper functions I'm using, and the initialization / finialization routines that have to be done to integrate with the plugin properly. Note that sample.php is automatically skipped by the plugin when executing scripts Quote Link to comment
ljm42 Posted May 11, 2016 Share Posted May 11, 2016 - Ability to only run the write checks on disks already spun up Thank you - Checks against docker applications installed where the user has changed the Container Port (more of a problem on 6.1.x as 6.2 tries to hide the setting better, but still quite possible for a user to do this), and doing it will almost guarantee the app won't work (thanks CHBMB for being a PITA ) Impressive! - Ability for user scripts to check for and add to the errors / warnings / other notes section of the plugin. Wow! Quote Link to comment
JonathanM Posted May 11, 2016 Share Posted May 11, 2016 Another thing to check for, docker mappings that point to RAM instead of a physical storage device. This warning should be qualified by valid use cases like transcoding in RAM, however, I would suggest also doing a RAM calculation and if the total amount of RAM is less than maybe 8GB, or the amount of RAM available for files is less than (X)GB then the warning would qualify for the Errors section. Quote Link to comment
Squid Posted May 11, 2016 Author Share Posted May 11, 2016 Another thing to check for, docker mappings that point to RAM instead of a physical storage device. This warning should be qualified by valid use cases like transcoding in RAM, however, I would suggest also doing a RAM calculation and if the total amount of RAM is less than maybe 8GB, or the amount of RAM available for files is less than (X)GB then the warning would qualify for the Errors section. Undecided about that, because right off the top of my head, cAdvisor will fail because it has 4 paths, all of which are pointed at somewhere within RAM (to grab information from the base OS). Maybe build an exception for it? but good idea though.. That, and I mount my external smb shares within /tmp so that no matter what unRaid can shutdown if UD has issues unmounting its mounts within /mnt/disks Quote Link to comment
RobJ Posted May 11, 2016 Share Posted May 11, 2016 Here's a big one *if* you are interested. A number of users with problems appear to have a full /var/log, causing additional problems for them. You are checking and reporting if it's filling up, but it would be really great if you could *truncate* the huge space wasters, and instantly give them some more space and time. It could possibly enable diagnostics collection, and powerdown, and any other safe procedures they might want to run, perhaps to diagnose further what's wrong. This is of course an action, a fix, not just a detection and report. We discussed this around here, and you questioned the loss of logging info after truncation, a valid quibble. I don't know if you still feel the same, but I still feel that data past the first 500KB is totally useless, not even worth saving, unless someone can come up with a valid reason why it might be useful. jonathanm's subsequent remark was apropos, although I'd rather not save the truncated garbage. Burn it! I do still think it could be a big help, allow them to continue a bit longer, long enough to grab full diagnostics. And the very fact it worked (if it does!) allows helpers to narrow the real problem down sooner. I'd loop through the files there, and truncate any that are larger than 5MB down to 2MB. Those are my suggested numbers, change as you like. Quote Link to comment
RobJ Posted May 11, 2016 Share Posted May 11, 2016 Another item to check, if you are interested, is the ps report, checking for processes that are monopolizing the CPU. I admit I don't have a lot of Linux experience, but it's hard for me to believe that any process should ever be using more than 90% of the CPU. I cringe when I see users reporting that something is using 100% CPU. Things don't work right if that's true. Interrupts won't be handled in a timely way, and that causes spurious timeouts and freezes in devices and processes that are otherwise completely fine, except they are starved for CPU attention. Helpers can then be mislead by these timeouts and subsequent errors, when all that device or process needed was some CPU love. The real problem is the runaway process hogging the CPU. A potential future fix would be to display the offending process, and request permission to kill it. Quote Link to comment
John_M Posted May 11, 2016 Share Posted May 11, 2016 Should this be considered to be a false positive? The plugin dynamix.smart.drivedb.plg is not known to Community Applications and is possibly incompatible with your server EDIT: I should add that the SMART drive database updater plugin is one of bonienl's and it first appeared here: https://lime-technology.com/forum/index.php?topic=47875.msg461469#msg461469. I'm using it with both unRAID 6.1.9 and 6.2.0-beta21. Quote Link to comment
Squid Posted May 11, 2016 Author Share Posted May 11, 2016 Under the criteria it is a valid error. However since its from bonienl it can be considered a false positive. This is why this is a warning and not an error. Only way to do things to get rid of the 6.0 plugins While bonienl may disagree my opinion is that any plugin not published in CA is potentially an issue. But this is a special circumstance . (i actually tested this routine by installing that plugin as I knew it wouldn't cause any issues) Sent from my LG-D852 using Tapatalk Quote Link to comment
John_M Posted May 12, 2016 Share Posted May 12, 2016 That's OK. Thanks for replying. As you say, it's a warning, not an error - I can ignore it. There are three other warnings and two error messages that I ignore too. They're all related to my not having auto-updates enabled - I simply don't like things auto-updating and I'm happy to take the responsibility for manually updating. I would prefer it if they were all warnings, rather than two ("Plugin Update Check not enabled" and "This plugin (Fix Common Problems) not set to auto update") being errors, but again, I can ignore them. Quote Link to comment
bonienl Posted May 12, 2016 Share Posted May 12, 2016 Under the criteria it is a valid error. However since its from bonienl it can be considered a false positive. This is why this is a warning and not an error. Only way to do things to get rid of the 6.0 plugins While bonienl may disagree my opinion is that any plugin not published in CA is potentially an issue. But this is a special circumstance . (i actually tested this routine by installing that plugin as I knew it wouldn't cause any issues) Sent from my LG-D852 using Tapatalk I never gave this particular plugin an official status, so your tool is right. Better warn people than to ignore. I foresee a temporary life for this plugin anyway. The issue is corrected in unRAID 6.2 and it can be considered to backport fixes into unRAID 6.1 as well (ultimately this is a LT decision). Quote Link to comment
bonienl Posted May 12, 2016 Share Posted May 12, 2016 Another thing to consider as part of the fixes is a warning about Adblockers, potentially interfering with the operation of the webGUI. If you are interested, I developed some detection code at the time (but it was never implemented in the webGUI) and show a warning when a running adblocker is detected. You could do something similar in your plugin, which would be a more appropriate place to do. Quote Link to comment
Squid Posted May 12, 2016 Author Share Posted May 12, 2016 Another thing to consider as part of the fixes is a warning about Adblockers, potentially interfering with the operation of the webGUI. If you are interested, I developed some detection code at the time (but it was never implemented in the webGUI) and show a warning when a running adblocker is detected. You could do something similar in your plugin, which would be a more appropriate place to do. That would be sweet Quote Link to comment
Squid Posted May 12, 2016 Author Share Posted May 12, 2016 That's OK. Thanks for replying. As you say, it's a warning, not an error - I can ignore it. There are three other warnings and two error messages that I ignore too. They're all related to my not having auto-updates enabled - I simply don't like things auto-updating and I'm happy to take the responsibility for manually updating. I would prefer it if they were all warnings, rather than two ("Plugin Update Check not enabled" and "This plugin (Fix Common Problems) not set to auto update") being errors, but again, I can ignore them. I want those two to be errors, because without autoupdate, I think that the fix plugin winds up being rather pointless if its running in the background, and the new checks don't get automatically pulled into it. But, I can also see your point (and RobJ's). I'll add an option to degrade those down to warnings (so at least on background checks you can leave notifications on), but I'm not going to add a drop down to select it. Rather it'll be some file or something on the flashdrive you create to set it to downgrade. That way, the I can have my way by default, and you can get yours. The last thing I want is for people to run background checks and ignore errors Quote Link to comment
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.