Description: Probably not many users going to run into this one but there was already one.

 

How to reproduce:

 

-Start with a valid single parity array.

-Replace parity, start array, cancel parity sync, stop array

-With parity still invalid, replace any other array disk

 

Expected results: Not being able to start array due to too many invalid disks

 

Actual results: Array will start and try to sync parity and rebuild disk at the same time:

Mar 19 14:40:02 Tower kernel: mdcmd (43): check correct
Mar 19 14:40:02 Tower kernel: md: recovery thread: recon P D2 ...
Mar 19 14:40:02 Tower kernel: md: using 1536k window, over a total of 3907018532 blocks.
Mar 19 14:40:02 Tower kernel: md: recovery thread: multiple disk errors, sector=0
Mar 19 14:40:02 Tower kernel: md: recovery thread: multiple disk errors, sector=8
Mar 19 14:40:02 Tower kernel: md: recovery thread: multiple disk errors, sector=16

...

Sync completes in impossible fast time and turns both disks green:

Mar 19 15:19:18 Tower kernel: md: sync done. time=2356sec

 

Other information: In this example the user was also trying to format the new dis making unRAID crash.

Mar 19 16:03:27 Tower emhttp: shcmd (179): set -o pipefail ; mkfs.xfs -m crc=1,finobt=1 -f /dev/md2 |& logger
Mar 19 16:03:27 Tower kernel: ------------[ cut here ]------------
Mar 19 16:03:27 Tower kernel: kernel BUG at drivers/md/unraid.c:445!
Mar 19 16:03:27 Tower kernel: invalid opcode: 0000 [#1] PREEMPT SMP
Mar 19 16:03:27 Tower kernel: Modules linked in: ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_conntrack_ipv4 nf_nat_ipv4 iptable_filter ip_tables nf_nat md_mod bonding kvm_amd kvm k10temp i2c_piix4 i2c_core ahci libahci pata_jmicron r8169 mii sata_sil24 acpi_cpufreq [last unloaded: md_mod]
Mar 19 16:03:27 Tower kernel: CPU: 0 PID: 2291 Comm: mkfs.xfs Not tainted 4.9.10-unRAID #1
Mar 19 16:03:27 Tower kernel: Hardware name: MSI MS-7623/880GMA-E45 (MS-7623), BIOS V17.9 12/06/2010
Mar 19 16:03:27 Tower kernel: task: ffff88011abca280 task.stack: ffffc90003630000
Mar 19 16:03:27 Tower kernel: RIP: 0010:[<ffffffffa0344be6>]  [<ffffffffa0344be6>] unraid_make_request+0x373/0x4bd [md_mod]
Mar 19 16:03:27 Tower kernel: RSP: 0018:ffffc900036339b0  EFLAGS: 00010202
Mar 19 16:03:27 Tower kernel: RAX: ffff8800cdf78fa8 RBX: 0000000000000002 RCX: ffff880116a7fc00
Mar 19 16:03:27 Tower kernel: RDX: 0000000000000001 RSI: 0000000000000006 RDI: ffff8800cdf78f1c
Mar 19 16:03:27 Tower kernel: RBP: ffffc900036339f8 R08: 0000000000000000 R09: 0000000000000001
Mar 19 16:03:27 Tower kernel: R10: ffffc90003633818 R11: 00000000002d1d1b R12: ffff880116a7fc00
Mar 19 16:03:27 Tower kernel: R13: 0000000000000088 R14: ffff8800cdf78ee0 R15: ffff88007f825800
Mar 19 16:03:27 Tower kernel: FS:  00002b0469b03540(0000) GS:ffff88011fc00000(0000) knlGS:0000000000000000
Mar 19 16:03:27 Tower kernel: CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
Mar 19 16:03:27 Tower kernel: CR2: 00002b0469b23000 CR3: 00000000cc15f000 CR4: 00000000000006f0
Mar 19 16:03:27 Tower kernel: Stack:
Mar 19 16:03:27 Tower kernel: ffff8800cdf78f1c 0000000000000100 ffff880116a7fc00 0000000116a7f9e0
Mar 19 16:03:27 Tower kernel: ffff88007f825800 ffff880118948000 0000000000000002 ffff88007f825800
Mar 19 16:03:27 Tower kernel: ffff88011abca280 ffffc90003633a38 ffffffffa033fbc0 0000000000000000
Mar 19 16:03:27 Tower kernel: Call Trace:
Mar 19 16:03:27 Tower kernel: [<ffffffffa033fbc0>] md_make_request+0x73/0xc8 [md_mod]
Mar 19 16:03:27 Tower kernel: [<ffffffff81382a30>] generic_make_request+0xb8/0x156
Mar 19 16:03:27 Tower kernel: [<ffffffff81382bca>] submit_bio+0xfc/0x105
Mar 19 16:03:27 Tower kernel: [<ffffffff811509d8>] __blockdev_direct_IO+0x23f7/0x3615
Mar 19 16:03:27 Tower kernel: [<ffffffff8114da90>] ? __blkdev_get+0x2f9/0x3a8
Mar 19 16:03:27 Tower kernel: [<ffffffff8114c17b>] ? I_BDEV+0xd/0xd
Mar 19 16:03:27 Tower kernel: [<ffffffff8114c76e>] blkdev_direct_IO+0x2e/0x30
Mar 19 16:03:27 Tower kernel: [<ffffffff8114c76e>] ? blkdev_direct_IO+0x2e/0x30
Mar 19 16:03:27 Tower kernel: [<ffffffff810c5a81>] generic_file_direct_write+0xa3/0x114
Mar 19 16:03:27 Tower kernel: [<ffffffff810c5b96>] __generic_file_write_iter+0xa4/0x172
Mar 19 16:03:27 Tower kernel: [<ffffffff8114ceda>] blkdev_write_iter+0x85/0xda
Mar 19 16:03:27 Tower kernel: [<ffffffff81120dd8>] __vfs_write+0xc3/0xec
Mar 19 16:03:27 Tower kernel: [<ffffffff81120dd8>] ? __vfs_write+0xc3/0xec
Mar 19 16:03:27 Tower kernel: [<ffffffff811217bf>] vfs_write+0xcd/0x176
Mar 19 16:03:27 Tower kernel: [<ffffffff811225b0>] SyS_pwrite64+0x5e/0x7e
Mar 19 16:03:27 Tower kernel: [<ffffffff8167d2b7>] entry_SYSCALL_64_fastpath+0x1a/0xa9
Mar 19 16:03:27 Tower kernel: Code: 00 74 02 0f 0b 48 83 b8 48 01 00 00 00 74 02 0f 0b 48 8b b0 30 01 00 00 f7 c6 00 10 00 00 74 02 0f 0b 83 b8 50 01 00 00 00 74 02 <0f> 0b 41 8b 7f 14 c1 ef 1d 75 09 4c 89 b8 38 01 00 00 eb 59 4c
Mar 19 16:03:27 Tower kernel: RIP  [<ffffffffa0344be6>] unraid_make_request+0x373/0x4bd [md_mod]
Mar 19 16:03:27 Tower kernel: RSP <ffffc900036339b0>
Mar 19 16:03:27 Tower kernel: ---[ end trace a5c3030ba06715b3 ]---
Mar 19 16:03:27 Tower kernel: note: mkfs.xfs[2291] exited with preempt_count 1

 

Yeah this is probably not good.......