[Plugin] Docker Folder


Recommended Posts

I was adding a new container to an existing folder and after clicking submit it seemed like nothing happened (but it was most likely just a bit slow to load) so I clicked again. After that, all my folders were gone and the Docker page showed the error message: "Warning: Invalid argument supplied for foreach() in /usr/local/emhttp/plugins/docker.folder/include/add-update.folder/import-export.php on line 8".

 

I checked /boot/config/plugins/docker.folder/folders.json and saw it was malformed + a duplicate key had been created for the folder I was adding to. Good thing there's a backup :)

 

Anyhoo, it would be nice if this sort of thing could be prevented, i.e. not allowing duplicate keys to be written and/or disabling the submit button after it's clicked.

Link to comment
5 minutes ago, KnifeFed said:

I was adding a new container to an existing folder and after clicking submit it seemed like nothing happened (but it was most likely just a bit slow to load) so I clicked again. After that, all my folders were gone and the Docker page showed the error message: "Warning: Invalid argument supplied for foreach() in /usr/local/emhttp/plugins/docker.folder/include/add-update.folder/import-export.php on line 8".

 

I checked /boot/config/plugins/docker.folder/folders.json and saw it was malformed + a duplicate key had been created for the folder I was adding to. Good thing there's a backup :)

 

Anyhoo, it would be nice if this sort of thing could be prevented, i.e. not allowing duplicate keys to be written and/or disabling the submit button after it's clicked.

Thanks for the report, did have a piece of code that disabled the submit after it was click but i guess it broke :(
Will update later today with a fix :)

  • Thanks 1
Link to comment
Posted (edited)
25 minutes ago, KnifeFed said:

I've noticed that when restarting a container, the log- and globe icons start spinning. Is this intentional? Here's a screenshot of what I'm referring to.

This is not international but as the code that makes it spin is not from docker-folder I can't really fix it :(

edit:
Just took another look, and it turns out that I was already modifying the function that was responsible for making the icon spin.
Just pushed and update with a fix, should have check before posting :$

Edited by GuildDarts
update with fix
  • Thanks 1
Link to comment
29 minutes ago, GuildDarts said:

This is not international but as the code that makes it spin is not from docker-folder I can't really fix it :(

Yeah, I see now that it puts the 'fa-spin' class on every <i> element within the container. Would it be possible to either put an inline style like:

<i style="-webkit-animation: none !important; animation: none !important;"...>

on the icons where it's not wanted or inject some global CSS, like:

.fa-navicon.fa-spin, .fa-globe.fa-spin { -webkit-animation: none !important; animation: none !important; }

?

Link to comment
1 hour ago, GuildDarts said:

edit:
Just took another look, and it turns out that I was already modifying the function that was responsible for making the icon spin.
Just pushed and update with a fix, should have check before posting :$

Nice, thanks!

Link to comment
  • 3 weeks later...

@GuildDarts I finally upgraded my system to 6.9.2 and with that I updated your plugin to latest version too. But with that I got this:

 

docker-folder.jpg.432702c66241943cf255ade3375db6e8.jpg 

 

Empty column taking 1/5 or 1/6 of my browser window width. Is it possible to turn this column off somehow? I mostly use Docker dialogs instead of Folder dropdown/expand list so it's complete waste of valuable space for me.

Link to comment

  

4 hours ago, Mr_Jay84 said:

Has there been any reports of system instability using this plug-in?

Nothing that I can think of, there have been a few bugs where your folders would disappear or a script would loop forever, but nothing crazy as of late :)

 

 

4 hours ago, bambi73 said:

@GuildDarts I finally upgraded my system to 6.9.2 and with that I updated your plugin to latest version too. But with that I got this:

 

docker-folder.jpg.432702c66241943cf255ade3375db6e8.jpg 

 

Empty column taking 1/5 or 1/6 of my browser window width. Is it possible to turn this column off somehow? I mostly use Docker dialogs instead of Folder dropdown/expand list so it's complete waste of valuable space for me.

Just pushed an update with this its under the global settings :) (Nuke uptime column)

Link to comment
4 minutes ago, GuildDarts said:

  

Nothing that I can think of, there have been a few bugs where your folders would disappear or a script would loop forever, but nothing crazy as of late :)

 

 

Just pushed an update with this its under the global settings :) (Nuke uptime column)

I installed the plugin a few weeks back and had issues with the machine becoming completely unresponsive via both Web and SSH that included all the running dockers. This happened almost every day until I uninstalled it a few days back. I assumed it was other dockers that I had installed since then.

 

I don't have any proof of this though as there was never anything in the logs at all. I had discounted the possibility of the crashes were due to this, but everything is back to normal once uninstalled.

 

I'll give it another go in a few weeks again as it's a very good addition to unRaid. I need the server for some vital tasks at present.

Link to comment
5 minutes ago, Mr_Jay84 said:

I installed the plugin a few weeks back and had issues with the machine becoming completely unresponsive via both Web and SSH that included all the running dockers. This happened almost every day until I uninstalled it a few days back. I assumed it was other dockers that I had installed since then.

 

I don't have any proof of this though as there was never anything in the logs at all. I had discounted the possibility of the crashes were due to this, but everything is back to normal once uninstalled.

 

I'll give it another go in a few weeks again as it's a very good addition to unRaid. I need the server for some vital tasks at present.

I can't think of anything the plugins does that would mess with SSH. Weird that it stopped when you uninstalled but glad that your server it no longer crashing/unresponsive
Hope it works next time you try it :)

Link to comment
Just now, GuildDarts said:

I can't think of anything the plugins does that would mess with SSH. Weird that it stopped when you uninstalled but glad that your server it no longer crashing/unresponsive
Hope it works next time you try it :)

Neither can I! That's what took me so long to find out why it was crashing. Very strange.

 

Thinking back though, at one point I had an issue where I selected "animate on hover" which caused the folder to disappear and the UI to become unresponsive. Eventually I managed to delete the folder and recreate it.

 

Maybe this happened twice. I wonder if it's linked.

Link to comment
3 minutes ago, Mr_Jay84 said:

Neither can I! That's what took me so long to find out why it was crashing. Very strange.

 

Thinking back though, at one point I had an issue where I selected "animate on hover" which caused the folder to disappear and the UI to become unresponsive. Eventually I managed to delete the folder and recreate it.

 

Maybe this happened twice. I wonder if it's linked.

I think someone else reported an issue with "animate on hover" a while back think it was broken on safari
Just tried to enable the option on one of my folders but nothing broke. Either the issue is fixed now (please this) or it's a combination or options that breaks it
Please do report it if you find the issue when you try again :)

Link to comment
8 hours ago, superloopy1 said:

How do i uninstall this docker folder business, not really got any use for it and its chucking out scary messages cant see any uninstall anywhere? This cant be right ...

 

The same place you uninstall any plugin, the plugins page
brave_jfSc4LJ0Cf.thumb.png.edc5a1043c8d588792cd4fa06cb57482.png

Link to comment

I'm getting an error when trying to install... However, reading the last few posts here I'm wondering if I should install or if there are issues with the latest version of unraid? 

 

Anyway, the error i'm getting is: 

Warning: mkdir(): Read-only file system in /usr/local/emhttp/plugins/dynamix.plugin.manager/scripts/plugin on line 264
plugin: unable to create parent directory for /boot/config/plugins/docker.folder/docker.folder-2021.07.04-x86_64-1.txz

 I'm not sure if there's a larger issue that just this plugin, but i'm looking at this post and currently "scurbbing" the cache drive just as a step 1. I'm not very unraid savvy yet, but trying! Any suggestions would be great! 

Link to comment
6 minutes ago, BirdHeezy said:

I'm getting an error when trying to install... However, reading the last few posts here I'm wondering if I should install or if there are issues with the latest version of unraid? 

 

Anyway, the error i'm getting is: 


Warning: mkdir(): Read-only file system in /usr/local/emhttp/plugins/dynamix.plugin.manager/scripts/plugin on line 264
plugin: unable to create parent directory for /boot/config/plugins/docker.folder/docker.folder-2021.07.04-x86_64-1.txz

 I'm not sure if there's a larger issue that just this plugin, but i'm looking at this post and currently "scurbbing" the cache drive just as a step 1. I'm not very unraid savvy yet, but trying! Any suggestions would be great! 

Yeah, I think this is a general unraid issue never seen it before tho. My best guess would be something is wrong with your usb but thats just a guess. If someone else does not chime in here I would suggest making a new thread under general support
Hope you can find a fix ^_^

  • Like 1
Link to comment
40 minutes ago, GuildDarts said:

Yeah, I think this is a general unraid issue never seen it before tho. My best guess would be something is wrong with your usb but thats just a guess. If someone else does not chime in here I would suggest making a new thread under general support
Hope you can find a fix ^_^

Swapped out my flash drive... all good now! Thanks! 

Link to comment
18 hours ago, shaunmccloud said:

Any idea why I'm getting this from Docker Folders on the VM tab but not the Docker tab?

2021-07-14 12_44_43-BB-8_VMs.png

The docker and vm folders are 2 different files. Looks like something bad happened to the folders-vm file
You can take a look at the file in /boot/config/plugins/docker.folder/folders-vm.json you might be able to spot whats wrong, or you can attach it in a post if you want and i take a look. You can also just delete the file that will make the error go away, but you will lose your folders :(
Sorry that this happened thought i had ironed out all this issues *sigh. Do you have any idea what cause it so that i might fix it?

Link to comment

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.