Jump to content

The Big Stink

Members
  • Posts

    9
  • Joined

  • Last visited

Posts posted by The Big Stink

  1. No.  Searching by PID can just give more results (older than 7 days).

     

    The option

     

    --modes 

     

    sets the quality.  Binhex's script uses

     

    --modes=flashhd,flashvhigh,flashhigh,flashstd,flashnormal,flashlow

     

    You could try

     

    --modes best 

     

    which downloads HD if available then falls back to SD, but I'm pretty sure that should be equivalent to Binhex's string anyway.

  2. As far as I know, you just have to get it from the URL for the iPlayer webpage.  I don't think you can get it from get_iplayer.

     

    In terms of the above code, it makes a big assumption that the entered Series and entered PIDs match.

     

    I think something like this would work better (although I haven't tied it):

     

    /usr/bin/get_iplayer --profile-dir /config --pid --nopurge --modes=flashhd,flashvhigh,flashhigh,flashstd,flashnormal,flashlow --file-prefix="<nameshort>- <senum> - <episodeshort>" "${PIDLIST[index]}" --pid-recursive --output "/data/get_iplayer/incomplete/<nameshort>"

     

    The loop would need editing in case only PIDs were entered and therefore SHOWLIST was empty (and I don't think you can save your Docker config without entering a value for the Series variable), but I'm probably telling you what you already know!

  3. This link gives the reason for preferring PID search rather than show search. 

     

    https://github.com/get-iplayer/get_iplayer/wiki/faq

     

    I'm new to Bash scripting so don't laugh....

     

    # split comma seperated string into list from PID env variable
    IFS=',' read -ra PIDLIST <<< "${PID}"

     

    Then modified your loop to:

     

    # process each show in the list
    for index in "${!SHOWLIST[@]}"; do

     

    And added a test to see if PIDs are being used:

     

    if [[ -n "${PID}" ]]; then 
    		echo "[info] Running get_iplayer on PIDs..."
    		# run get_iplayer for PID, saving to incomplete folder
    		/usr/bin/get_iplayer --profile-dir /config --pid --nopurge --modes=flashhd,flashvhigh,flashhigh,flashstd,flashnormal,flashlow --file-prefix="${show_name} - <senum> - <episodeshort>" "${PIDLIST[index]}" --pid-recursive --output "/data/get_iplayer/incomplete/${show_name}"
    	else
    		# run get_iplayer for show, saving to incomplete folder
        	echo "[info] Running get_iplayer on shows..."
        	/usr/bin/get_iplayer --profile-dir /config --get --nopurge --modes=flashhd,flashvhigh,flashhigh,flashstd,flashnormal,flashlow --file-prefix="${show_name} - <senum> - <episodeshort>" "${show_name}" --output "/data/get_iplayer/incomplete/${show_name}"
        fi

     

    Basically you use --pid instead of --get.  Also make sure --pid-recursive is added.

     

    There are probably cleaner ways to do this, as you can probably get the showname from get_iplayer (c.f. with your <senum> and <episodeshort> parameters), but it was just a test to see if I could get it working.

     

  4. Get-iplayer is great, so thanks to binhex for making a Docker of it.

     

    Just a suggestion - it might be a good idea to include an option of searching by PID, as this can result in more shows being downloaded.

     

    I have this working for me - I just added a new variable "PID" to your Docker and edited your start.sh script.  The script gets overwritten every time I edit the Docker or if it gets updated, so it would be nice if you could add something similar?

     

     

×
×
  • Create New...