Jump to content
  • [6.12.4] Share free space always includes first disk containing folder, even if excluded.


    RiffSphere
    • Urgent

    Hi,

     

    When creating a share with only primary storage set to array, and excluding all disks, instead of creating a share with 0 bytes free, it will not create a share, and it doesn't give an error:

    https://imgur.com/fAg6AZy

    I can understand the share is not being created, since there is no disk to create the folder on, but an error message would be nice.

     

    A bigger issue is if the share is already created and disks get excluded. This is my share with all disks included:

    https://imgur.com/W37KaBG

    Editing the share and excluding all disks:

    https://imgur.com/sBAMGT7

    And the share still shows free space (this matches the size of my disk1, containing the folder):

    https://imgur.com/zwNb3Ik

    Clicking the compute button will even tell me the size is 6B and disk 1 is out of designated disks:

    https://imgur.com/bE1G8r3

     

    I created a "test" folder on disk2 as well:

    https://imgur.com/ce1gPgM

    Now the free space is showing the sum of the 2 disks. Compute does report correctly though:

    https://imgur.com/zHmmyDc

     

    Making a file file on an excluded disk, also still shows the file in the share:

    https://imgur.com/fdQzWxh

    Editing (even after removing disk2 from excluded disks) or deleting the file, will update this on disk1

    https://imgur.com/95szcq0

    Even if the file edit is relative big, it still works:

    https://imgur.com/9C30KGF

     

    I understand that https://docs.unraid.net/unraid-os/manual/shares/user-shares/#included-or-excluded-disks states "Never set both values, set only the one that is most convenient for you.", but if I don't select any specific disks as included, it defaults to "all", with no option to not set this. This makes the exclude function worthless, the only way to exclude a disk is to not have it in the included disks to begin with (something I don't want, cause I want all current and future disks available to a share, apart from 1 disk I want to exclude, and setting specific included disks will not add my future disks). I really think we need an "all except excluded" option for included.

     

    To make things more confusing, when trying to create a file on a share with all disk excluded, but reporting free space, I get the error of no space left, even when df is showing free space:

    https://imgur.com/vPb2fnX

    So in some way, the exclude is being done? But partially?

     

    So I'm really confused now:

    - Included disks have priority over excluded disks, but I have no good way to make use of excluded disks.

    - Free space on excluded counts towards the free space reported by the share.

    - Existing files on excluded disks are listed, can be opened, edited and deleted without issues.

    So far, while I don't like it, it still follows "all disks are included so the excluded disks does nothing".

    - Making a new file will tell me there is no space, though everything indicates to me there is space, and I can even edit existing files and make them a lot bigger.




    User Feedback

    Recommended Comments

    Quote

    but if I don't select any specific disks as included, it defaults to "all", with no option to not set this.

     

    Not following, if you don't want to use all just include only the disks you want to use for that share, or exclude the ones you don't want included.

    Link to comment
    36 minutes ago, JorgeB said:

     

    Not following, if you don't want to use all just include only the disks you want to use for that share, or exclude the ones you don't want included.

    Say I have 3 disks now.

     

    I make a share (lets say "backup") that I want to only include disk 1. This is easy, include disk 1.

     

    Now I make another share (say "media") that I want to include all but disk 1. I could indeed set included disks to disk 2 and disk 3. However, in 3 months my disks are full, and I add disk 4. Now I have to remember to include disk 4 in my share, or it wont be used. 

     

    The other option is to not set any included disks, and it will default to "all". If I now add disk 1 to excluded, it does indeed work as expected: every disk that is not disk 1, current or future disks, will be in the media share.

     

    The issue is: If for some reason disk 1 has a "media" folder in it's root (because I did not include it when I originally included the share for example, or because I have a script that does output to that folder while it shouldn't), the free space of disk 1 is being included as free space for the share. If there are files or folders in disk1/media, those files and folders can be opened, edited and removed. The only thing I can't do is create new files on disk1. So the share would show empty space left if all other disks are full, but still report there is no space when creating the file.

     

    So the disk isn't really excluded. It won't make the /mnt/disk1/media folder by itself, but it will still list the content if it exists. It doesn't allow me to make new files/foldes in /mnt/disk1/media, but I can do anything with existing ones, and even with all other disks full I can change a small file into a big one, with the changes ending up in /mnt/disk1/media.

    Link to comment
    10 minutes ago, RiffSphere said:

    The issue is: If for some reason disk 1 has a "media" folder in it's root (because I did not include it when I originally included the share for example, or because I have a script that does output to that folder while it shouldn't), the free space of disk 1 is being included as free space for the share.

    This is normal, because if that disk contains the share any files there will still be visible when browsing the share, only any new files added would respect the included/excluded settings.

    Link to comment

    You might call it normal, but that's not what I expect from an "excluded" disk.

    If I exclude something, I don't want it in there.

     

    Again, I understand that include is handled over exclude, but I don't have the option for "all but excluded", that would fix the issue.

     

    (I tried to make it a general bug report, with examples of how and why I expected things to behave differently, but it was made after seeing and testing this reddit post: 

     The user did create a share, then for some reason decided to exclude all his disks, only to get errors that there is no space left while everything indicates there is, with no errors or warnings about a misconfiguration).

     

    Edit:

    Also, from what I read in the docs (again, other than it technically being included by the "all") at https://docs.unraid.net/unraid-os/manual/shares/user-shares/#included-or-excluded-disks, it is not normal:

    "Specify the disks to exclude here. For example, set the excluded disk(s) to "disk1,disk2" to restrict a share from using disk1 and disk2."

    Edited by RiffSphere
    Link to comment

    Did you miss the point that those settings only apply to NEW files folders.    Existing files.folders for a share will be found on all drives regardless of the include/exclude settings.

    Link to comment

    I seem to have indeed read over that big info box, my bad 🤐

     

    However, that same box states "Files on other disks that are in a folder corresponding to the share name will still show up under that share for read purposes.", and I can change and delete the files on the excluded disk, and they are not read actions. It also doesn't state that the free space of that disk will be added to the share free space, even though it's not writable.

     

    The docs also state that " If no drives are specified under these settings then all drives allowed under Settings > Global Share settings are allowed", with not option to not configure the included disks.

     

    Bottom line is, the include and exclude is really unclear, and the docs don't make it clearer. I have a feeling that, with the changes to shares in 6.12, some settings were changed, with the docs not being updated.

     

    I personally don't agree that files in a folder matching the share name on an excluded disk should show up, but if that's by design, I guess it's not a bug. If there is a reason to do so, I'm also interested in knowing why. As for the other points, I still consider them bugs, as this imo illogical behavior is not documented (as far as I read, but seems I do miss some obvious things, so I apologize for that) as a designed feature.

    Link to comment


    Join the conversation

    You can post now and register later. If you have an account, sign in now to post with your account.
    Note: Your post will require moderator approval before it will be visible.

    Guest
    Add a comment...

    ×   Pasted as rich text.   Restore formatting

      Only 75 emoji are allowed.

    ×   Your link has been automatically embedded.   Display as a link instead

    ×   Your previous content has been restored.   Clear editor

    ×   You cannot paste images directly. Upload or insert images from URL.


  • Status Definitions

     

    Open = Under consideration.

     

    Solved = The issue has been resolved.

     

    Solved version = The issue has been resolved in the indicated release version.

     

    Closed = Feedback or opinion better posted on our forum for discussion. Also for reports we cannot reproduce or need more information. In this case just add a comment and we will review it again.

     

    Retest = Please retest in latest release.


    Priority Definitions

     

    Minor = Something not working correctly.

     

    Urgent = Server crash, data loss, or other showstopper.

     

    Annoyance = Doesn't affect functionality but should be fixed.

     

    Other = Announcement or other non-issue.

×
×
  • Create New...