ambipro

I assume that this is libtorrent 2.0.9 though? I'd like to stick with 1.2.x (1.2.19 preferrably) Are there plans to offer both with this fix?

No pressure, but I was just curious about when you were going to build and push the dumb-init fix and hopefully update libtorrent (dont forget 1.2.19 in libtorrentv1 branch :D) in the docker images? I assume that the fix worked out how you hoped? Just a curious

07:44:18 [DEBUG ][deluge.core.daemon :1622] Remove pid file: /config/deluged.pid 07:44:18 [INFO ][deluge.core.daemon :1622] Deluge daemon shutdown successfully 07:44:18 [INFO ][deluge.core.daemon_entry :1622] Exiting... deluged exited successfully. 07:44:18 [INFO ][deluge.ui.web.server :1622] Shutting down webserver 07:44:18 [DEBUG ][deluge.ui.web.server :1622] Saving configuration file For thoroughness here is deluge-web. 2023-11-13 07:49:28,099 DEBG fd 8 closed, stopped monitoring <POutputDispatcher at 22393937543568 for <Subprocess at 22393936472720 with name deluge-script in state RUNNING> (stdout)> 2023-11-13 07:49:28,099 DEBG fd 10 closed, stopped monitoring <POutputDispatcher at 22393936863952 for <Subprocess at 22393936472720 with name deluge-script in state RUNNING> (stderr)> 2023-11-13 07:49:28,099 INFO exited: deluge-script (exit status 0; expected) 2023-11-13 07:49:28,100 DEBG received SIGCHLD indicating a child quit 2023-11-13 07:49:46,117 WARN received SIGTERM indicating exit request and Docker logs from when container was stopped Plugins persisted as well. I did go back and test the old image under same conditions (empty config folder). These lines were missing from the logs when the container was stopped, but plugins intermittently did persist regardless. It may not be as consistent as I originally thought to reproduce that way, however it also may have something to do with there being no torrents present and deluged basically being idle throughout the test. Either way, the logs clearly show success in receiving SIGTERM, and waiting for the child processes to return status before container is stopped. I call this a success unless I'm missing something or it reacts differently with torrents loaded (I don't believe it would)

Alright can test this out right now. Just to reiterate, as I use 1.x libtorrent (which also has 1.2.19, https://pypi.org/project/libtorrent/#history) - and would love to see this and libtorrent updated in both tags when you merge and build the new images. I don't have an issue testing whatever libtorrent version you're using on this branch by the way Just reminding I'll setup a new container with that tag, and test what I've found the most reproducible steps are....just so you can replicate if desired, I'll be doing the following expecting it to work rather than fail. 1. New instance of Deluge with empty appdata /config dir 2. Attempt to enable ltConfig plugin (version doesn't seem to matter but we keep an updated version on our forums https://forum.deluge-torrent.org/viewtopic.php?p=236641#p236641) - Default plugins didn't seem to consistently fail to remain loaded for whatever under-the-hood reason. 3. Enable the plug-in in Deluge 4. Restart the container through the unraid UI Plugin should be disabled if the fix hasn't worked....otherwise it should remain (if memory serves). I'll post back when I've done this, if it fails or ungraceful shutdown in logs, will post deluged logs. For clarity, I'm using thin-client to do all of this.

You and me both, fortunately there are a few options available if dumb-init can't be worked.

Since I'm the provokation for @mhertz posting this reminder, and as I was going to reach out here myself, I'd like to point out what the request to address this revert/change provides for the user based on my experience using your container and conversations I've had with @mhertz A significant portion of the restarting of the container with the ungraceful shutdown can lead to settings being removed, particularly loaded plugins. These will thus not return upon restarting the container. The addition of -v on the info command makes it functional. Graceful shutdown prevents most errors that would otherwise occur with active/seeding torrents, and can also make sure your stats are sent to the tracker before Deluge is exited. Everything else mentioned in his previous posts/code he linked to... The main way to prevent most of these issues currently, that I have found and use, is to simply 'Quit & Shutdown' before restarting or stopping the container. I typically do this and wait about 20 seconds to be safe. This is not ideal, but is workable in most situations. Hoping some form of what has been suggested/mentioned gets added/fixed in both libtorrentv1 and v2 tags. Appreciate your containers and the effort put in, they've otherwise been phenomonal Edit: Also - off topic, but there is a newer version of libtorrent for v1