codechimp

I am getting the same issue, but only after having recently updated to Mojave, before that it was working fine.

Gets a +1 from me as well. ELK and GitLab would really benefit from being able to compose rather than hack together an all in one dockerfile.

i would recommend if you need specific tooling for certain projects, such as android dev then you really should consider creating a jenkins slave (node) and then install what you want on the node, installing everything on the master and running jobs on the master is not really the way to use jenkins. That's my plan long term. From what I've read slave nodes are the way to go though most tutorials use the master so I'll experiment like that to start with then re-fork and do things properly.

hi squid, thanks a ton for looking into this!, i didnt realise this was the issue, your quite right they are showing as corrupt, the wierd thing is the date stamp for the commit hasnt changed so the file should be the same, the other odd thing is that the local copy of the repo i have i can view all the images, no problems, how very strange!!. so did a quick bit of good old googling and found this rather useful article which shows of a more robust way of getting images uploaded to github without using the nasty raw format, thought i would share as i have just done this and it works a treat, now all i gotta do is change all my templates http://solutionoptimist.com/2013/12/28/awesome-github-tricks/ and the end result:- https://github.com/binhex/docker-templates/issues/22 pretty sweet hu, and as you can see the images are ok, so not sure why github had an issue, but there ya go, ive learnt a new trick in the process :-). Unfortunately this didn't work for me but I did find this little snippet about .gitattributes http://stackoverflow.com/questions/19411981/images-corrupt-after-git-push I just added the following from that and it seems to work. # Binary *.png binary btw, Great work with the images, I'm adapting your Jenkins for my own use and it's a great starting point. hi codechimp, firstly many thanks for posting, it lead me to do a bit more reading, i found this post very useful!:- https://help.github.com/articles/dealing-with-line-endings/ pretty basic stuff but something i never really spent much time looking into, shows how green i still am with github :-). in any case i put the changes into my gitattributes file and after a few stabs i got it correctly defined and the images are now up on github with no corruption, yay!. out of curiosity you mentioned that "Unfortunately this didn't work for me" im assuming your talking about the idea of creating an issue and uploading images and then linking to these?, it certainly seems to work for me and squid's forum post now correctly shows the icons so im pretty sure its working correctly, but this is a workaround and i prefer the idea of defining binary artifacts much more. glad your enjoying Jenkins, i use this at work for CI quite heavily now with Docker, having lots of fun running multiple dynamic Docker Jenkins nodes :-), the image could do with the inclusion of some tooling, such as git, python, ruby, mono etc, so might make that change at some point. I use images within my repo's without corruption issue so knew it was possible, it was just a matter of tracking down the differences between my own and your repo. I'm hardly a github expert either! Yes I was talking about the images via the issue. I may have grabbed it at the point where you were still experimenting so it might have worked if I had tried it now. I just got into unraid/your docker images this weekend so probably bad timing. I'm going to be using Jenkins for CI for my Android development. Totally new to me and I did need some addtional tooling hence why I forked your repo and started extending it. I'm a total noob to docker/jenkins so I'd not want to suggest pull requests until I know what I'm talking about.

hi squid, thanks a ton for looking into this!, i didnt realise this was the issue, your quite right they are showing as corrupt, the wierd thing is the date stamp for the commit hasnt changed so the file should be the same, the other odd thing is that the local copy of the repo i have i can view all the images, no problems, how very strange!!. so did a quick bit of good old googling and found this rather useful article which shows of a more robust way of getting images uploaded to github without using the nasty raw format, thought i would share as i have just done this and it works a treat, now all i gotta do is change all my templates http://solutionoptimist.com/2013/12/28/awesome-github-tricks/ and the end result:- https://github.com/binhex/docker-templates/issues/22 pretty sweet hu, and as you can see the images are ok, so not sure why github had an issue, but there ya go, ive learnt a new trick in the process :-). Unfortunately this didn't work for me but I did find this little snippet about .gitattributes http://stackoverflow.com/questions/19411981/images-corrupt-after-git-push I just added the following from that and it seems to work. # Binary *.png binary btw, Great work with the images, I'm adapting your Jenkins for my own use and it's a great starting point.