dorgan Posted May 2, 2020 Share Posted May 2, 2020 Is it not possible to override the default name of a menu that shows in the task bar? I see by default it uses the filename, but I want to include a space in the name of the menu item, can I do that? Quote Link to comment
Squid Posted May 2, 2020 Share Posted May 2, 2020 By having a space in the file name Quote Link to comment
dorgan Posted May 2, 2020 Author Share Posted May 2, 2020 1 hour ago, Squid said: By having a space in the file name Lol, I am so against that when it comes to programming, I didn't even think of that as an option LOL, thanks! Quote Link to comment
dorgan Posted May 2, 2020 Author Share Posted May 2, 2020 1 hour ago, Squid said: By having a space in the file name So this works but there is a bug with it, the active indicator doesn't show. Quote Link to comment
dorgan Posted May 2, 2020 Author Share Posted May 2, 2020 In fact it looks like it doesnt even try to execute the page... So you get the menu item but its not actually loading the page fully. Quote Link to comment
Squid Posted May 2, 2020 Share Posted May 2, 2020 Yeah, I'm seeing the same thing. Change it to PLEX_STREAMS Quote Link to comment
dorgan Posted May 2, 2020 Author Share Posted May 2, 2020 1 minute ago, Squid said: Yeah, I'm seeing the same thing. Change it to PLEX_STREAMS That works, but then the name of the menu has an underscore in it. If I could open a pull request for menus to have a name override I would jump right in and solve this. I guess for now I will go with the underscore Quote Link to comment
Squid Posted May 2, 2020 Share Posted May 2, 2020 6 minutes ago, dorgan said: If I could open a pull request for menus to have a name override I would jump right in and solve this. https://github.com/limetech/webgui Quote Link to comment
dorgan Posted May 2, 2020 Author Share Posted May 2, 2020 Just now, Squid said: https://github.com/limetech/webgui Perfect! Quote Link to comment
dorgan Posted May 2, 2020 Author Share Posted May 2, 2020 (edited) 18 minutes ago, Squid said: https://github.com/limetech/webgui Got the active tab being reflected, now just need name overrides. Edited May 2, 2020 by dorgan Quote Link to comment
dorgan Posted May 2, 2020 Author Share Posted May 2, 2020 39 minutes ago, Squid said: https://github.com/limetech/webgui Actually cleaner was to not even worry about the space in file name approach, because it still wasnt processing the content of those pages, so i just went with a simple Display_Name property and the PR is now open. Quote Link to comment
Squid Posted May 2, 2020 Share Posted May 2, 2020 It won't get approved unless you change it to ..."._($page)."... and ..."._($display_name)."... Has to be like like for translations that are forthcoming soon(tm) Quote Link to comment
dorgan Posted May 2, 2020 Author Share Posted May 2, 2020 1 minute ago, Squid said: It won't get approved unless you change it to ..."._($page)."... and ..."._($display_name)."... Has to be like like for translations that are forthcoming soon(tm) ok on it. Quote Link to comment
dorgan Posted May 2, 2020 Author Share Posted May 2, 2020 3 minutes ago, Squid said: It won't get approved unless you change it to ..."._($page)."... and ..."._($display_name)."... Has to be like like for translations that are forthcoming soon(tm) And Done Quote Link to comment
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.