Thanks for the report. I can reproduce this: on 7.3.3 and 7.4.0-rc.1, Unassigned Devices shows only a Format button for an NVMe device that already has a partition. On 7.3.2 the same device mounts normally.

This is a compatibility issue between Unassigned Devices and a udev change in 7.3.3. Your data is fine, but don't click Format. Until it's fixed, you can stay on or go back to 7.3.2.

Non-NVMe devices are not affected; I've reported it to LT and hopefully it will be fixed soon.

1 hour ago, JorgeB said:

Thanks for the report. I can reproduce this: on 7.3.3 and 7.4.0-rc.1, Unassigned Devices shows only a Format button for an NVMe device that already has a partition. On 7.3.2 the same device mounts normally.

This is a compatibility issue between Unassigned Devices and a udev change in 7.3.3. Your data is fine, but don't click Format. Until it's fixed, you can stay on or go back to 7.3.2.

Non-NVMe devices are not affected; I've reported it to LT and hopefully it will be fixed soon.

I've been debugging this too. Seems like it's a multiple alias problem:

The Unassigned Devices plugin has a weakness in its discovery logic:

1. It chooses one alias for the disk.

2. It independently chooses an alias for the partition.

3. It assumes their names match.

When they don't, the plugin incorrectly concludes that the disk has no partitions.

Patched like this:

cp /usr/local/emhttp/plugins/unassigned.devices/include/lib.php /tmp/ud-lib.php.before-alias-fix

sed -i '3595c\ $partitions = array_values(array_filter($devicePaths, function($alias, $real) use ($path) { return (bool) preg_match("#^".preg_quote($path, "#")."p?[0-9]+$#", $real); }, ARRAY_FILTER_USE_BOTH));' /usr/local/emhttp/plugins/unassigned.devices/include/lib.php

php -l /usr/local/emhttp/plugins/unassigned.devices/include/lib.php

And persisted the patch across reboots with this script

mkdir -p /boot/config/custom

cat > /boot/config/custom/ud-nvme-hotfix.sh <<'EOF'

#!/bin/bash

set -euo pipefail

lib=/usr/local/emhttp/plugins/unassigned.devices/include/lib.php

backup=/tmp/ud-lib-before-hotfix.php

# Wait for Unassigned Devices to be installed.

for i in {1..60}; do

[[ -f "$lib" ]] && break

sleep 1

done

[[ -f "$lib" ]] || exit 1

cp "$lib" "$backup"

# Fix NVMe parent device identification.

sed -i 's/MiscUD::base_device($matches\[1\]\[0\])/MiscUD::base_device($partition["device"])/' "$lib"

# Match partitions by real device path, not aliases.

sed -i '/\$partitions = array_values(preg_grep(/c\ $partitions = array_values(array_filter($devicePaths, function($alias, $real) use ($path) { return (bool) preg_match("#^".preg_quote($path, "#")."p?[0-9]+$#", $real); }, ARRAY_FILTER_USE_BOTH));' "$lib"

# Verify both fixes and PHP syntax; roll back on failure.

if ! grep -Fq 'MiscUD::base_device($partition["device"])' "$lib" ||

! grep -Fq 'array_values(array_filter($devicePaths' "$lib" ||

! php -l "$lib" >/dev/null; then

cp "$backup" "$lib"

logger -t ud-nvme-hotfix "Hotfix failed or plugin changed"

exit 1

fi

logger -t ud-nvme-hotfix "NVMe hotfix applied/verified"

EOF

chmod 755 /boot/config/custom/ud-nvme-hotfix.sh

and updated go file

cp -p /boot/config/go /boot/config/go.pre-ud-hotfix

grep -Fxq '/boot/config/custom/ud-nvme-hotfix.sh' /boot/config/go || \

sed -i '/^\/usr\/local\/sbin\/emhttp$/i /boot/config/custom/ud-nvme-hotfix.sh' /boot/config/go

grep -B2 -A2 '/usr/local/sbin/emhttp' /boot/config/go

Edited 11 hours ago11 hr by martindell