Need some help with a script

[wgstarks]

I've set up a script to clean .DS_Store files. Got the script from this post

#!/bin/bash
# ========================================================================== #
# Program Body                                                               #
# ========================================================================== #
((!$#)) && echo No Directory supplied! && exit 1

dir="$@"
echo $dir

echo "Removing .DS_Store files"
find "$dir" -name ".DS_Store" -exec rm '{}' \; -print

echo "======================="
echo "Removing ._ files"
find "$dir" -name "._*" -exec rm '{}' \; -print

 

 

I've got it installed in /config/plugins/DS_Store-Cleanup/ and run it with a cron entry-

# DS_Store Cleanup for Media:
20 3 * * 1 ./config/plugins/DS_Store-Cleanup/rmdotstore.sh /mnt/user/Media

 

 

I think it's working??? If I create a test file named .DS_Store it will get deleted when running the command via telnet at least. My problem is that I don't get any notifications. Is there something I can modify to have the system send a notification (preferred) or maybe at least have a log entry?

[Squid]

to have something logged, just use

logger This is the log entry I want

to use the notify system in unraid, use this command:

/usr/local/emhttp/plugins/dynamix/scripts/notify

(the options will display if you just enter the command by itself

 

[wgstarks]

Tried changing the script to this-

#!/bin/bash
# ========================================================================== #
# Program Body                                                               #
# ========================================================================== #
((!$#)) && echo No Directory supplied! && /usr/local/emhttp/plugins/dynamix/scripts/notify [-e "DS_Cleanup"] [-s "DS_Cleanup"] [-i "normal"] [-m "Cleaning DS_Store files from Media"] && exit 1

dir="$@"
echo $dir

echo "Removing .DS_Store files"
find "$dir" -name ".DS_Store" -exec rm '{}' \; -print

echo "======================="
echo "Removing ._ files"
find "$dir" -name "._*" -exec rm '{}' \; -print

 

I don't get an email though. Did I miss something?

 

Also tried running the command from telnet with the same result.

I'm guessing there's a syntax problem but I'm a noob at this so pretty much lost here.

[Squid]

I've never used that style with bash

 

I always use if and fi - makes more sense to me. 

 

[Squid]

Tried changing the script to this-

#!/bin/bash
# ========================================================================== #
# Program Body                                                               #
# ========================================================================== #
((!$#)) && echo No Directory supplied! && /usr/local/emhttp/plugins/dynamix/scripts/notify [-e "DS_Cleanup"] [-s "DS_Cleanup"] [-i "normal"] [-m "Cleaning DS_Store files from Media"] && exit 1

dir="$@"
echo $dir

echo "Removing .DS_Store files"
find "$dir" -name ".DS_Store" -exec rm '{}' \; -print

echo "======================="
echo "Removing ._ files"
find "$dir" -name "._*" -exec rm '{}' \; -print

 

I don't get an email though. Did I miss something?

 

Also tried running the command from telnet with the same result.

I'm guessing there's a syntax problem but I'm a noob at this so pretty much lost here.

duh... I'm dense.  Remove the braces from within the notify command

[wgstarks]

I've never used that style with bash

 

I always use if and fi - makes more sense to me. 

 

Probably would for me too if I had any idea what I was doing.

 

I just added it on to the cron script. Worked great. Thanks

# DS_Store Cleanup for Media:
20 3 * * 1 ./config/plugins/DS_Store-Cleanup/rmdotstore.sh /mnt/user/Media  && /usr/local/emhttp/plugins/dynamix/scripts/notify -e "DS_Cleanup" -d "Removing .DS_Store files" -i "normal" -m "Cleaning DS_Store files from Media"

 

I seem to remember that I need to restart my server for the cron files to load. Is that true?

[Squid]

Not sure how you're doing it.  I've only ever worked with cron thru crontab (and you don't need a restart that way)

[Squid]

But it seems to me that since the remove script doesn't run in the background that you're going to be notified after it runs.  Would probably make more sense to be notified prior to it's start

[wgstarks]

I added a folder to /config/plugins/

 

 

IF I'm understanding what I'm reading on various threads, I just set it up as a simple plugin.

[Squid]

You'd still have to get it installed via a plg

[wgstarks]

You'd still have to get it installed via a plg

Not sure what you mean???

[Squid]

 

 

I added a folder to /config/plugins/

IF I'm understanding what I'm reading on various threads, I just set it up as a simple plugin.

 

Explain what you mean by this then

[wgstarks]

I created a folder in plugins "DS_Store-Cleanup". Inside the folder are 2 text files "rmdotstore.cron" and "rmdotstore.sh".

I had read in the forum that I could run any script this way. All I had to do was model it after any of the plugins already on the flash drive. Wish I could find the thread.

[wgstarks]

Found it- http://lime-technology.com/forum/index.php?topic=44172.msg421807#msg421807

[kizer]

Stole this from your post up above for my little code. Thanks for sharing.

 

/usr/local/emhttp/plugins/dynamix/scripts/notify -e "DS_Cleanup" -d "Removing .DS_Store files" -i "normal" -m "Cleaning DS_Store files from Media"

 

Of course I modified it for my own needs, but I dig the notification.