Recycle Bin (vfs recycle) for SMB Shares


dlandon

794 posts in this topic Last Reply

Recommended Posts

The existing recycle bin does not work on the 6.3 final release.  I have updated it for 6.3 final, but it will not be backwards compatible because of changes in 6.3 to accommodate other features that broke the recycle bin.  This required the recycle bin to be rewritten.  The previous version will be deprecated.

 

Dan, respectfully, please don't terminate the previous version, there will be users who stay with older versions, that's just the way it is, probably always will be.  Just a note about the term 'deprecate', when you say something is deprecated, you aren't saying it's terminated, you are saying it's still available and completely usable, but that there's another option that is now preferred over it.  For example, Microsoft would say that Windows 7 is deprecated in favor of Windows 10.  Many users would disagree, and continue using it.

 

I would prefer that auto update be turned off for the previous version, so that the Recycle Bin still works for all users, no matter what version they decide to use.

 

I updated my post based on your comments to better reflect the situation as it could have been misleading the way it was originally written.  The old version will not be removed even if the user tries to upgrade the plugin.

Link to post
  • Replies 793
  • Created
  • Last Reply

Top Posters In This Topic

Top Posters In This Topic

Popular Posts

This is a plugin that will create a per share .Recycle.Bin folder on each smb share for files deleted on that share.  Built into samba is a module called "vfs recycle" that handles the deletion of fil

Shares were not displaying when "Log Deleted Files" was set to "No".  This has been fixed in the latest version.

No longer true.  I'm releasing a new version that will not show any remote mounted shares and the local recycle bin will not remove any files from the remote share recycle bins.  Only the local server

Posted Images

If you happened to have had CA AutoUpdate ever update the plugin, then an old .plg will be saved on the flash drive (config/plugins-old-versions) that you might be able to get away with by copying back to the plugins folder.  YMMV

 

(I can appreciate dlandon not wishing to support multiple versions of the plugin though)

Link to post

Since my SuperMicro motherboard doesn't seem to be compatible with 6.2+ does that mean I can no longer use recycle bin?

 

You can continue to use it.  If you try to update it, the new version will error out with a version error and the old version will stay.

Link to post

Can't he just reinstall it with ca?

If the plugin already got updated, then the autoupdate backup of the .plg is the only way to go back.

 

The current .plg will reference the most recent .txz (not to mention that CA won't even display the plugin unless you enable Show Incompatible Apps within CA settings)

 

The backup plg that AutoUpdate makes will reference an older dated txz (and md5) and will still install assuming that you haven't deleted old txz's from github

 

Besides, its the first time I've had the chance to flog that little feature of AutoUpdate (and been thinking about getting rid of it)

 

Link to post

Can't he just reinstall it with ca?

If the plugin already got updated, then the autoupdate backup of the .plg is the only way to go back.

 

The current .plg will reference the most recent .txz (not to mention that CA won't even display the plugin unless you enable Show Incompatible Apps within CA settings)

 

The backup plg that AutoUpdate makes will reference an older dated txz (and md5) and will still install assuming that you haven't deleted old txz's from github

 

Besides, its the first time I've had the chance to flog that little feature of AutoUpdate (and been thinking about getting rid of it)

 

All of old versions are left on github.

Link to post

Will the 6.2.4 version be compatible with 6.1.9? I have that version in my most recent backup but if I copy it to the plugins folder FCP gives a warning that it's not compatible. I know I can ignore it in FCP, just want to be sure it really is compatible with 6.1.9.

Link to post

Will the 6.2.4 version be compatible with 6.1.9? I have that version in my most recent backup but if I copy it to the plugins folder FCP gives a warning that it's not compatible. I know I can ignore it in FCP, just want to be sure it really is compatible with 6.1.9.

 

The older version is compatible with 6.1 through 6.2.

Link to post

Thanks for keeping up with this Dlandon!  This plugin has saved my skin and I now consider it a critical component

 

While I was testing the rc versions, one of the later rc's broke it and I can't believe how much I missed it.  This sucker saved my bacon many times.  With the new capability LT has given me, it is now much better because I can do a per share recycle bin.  The old way of doing it globally meant the recycle bin was on for every share in the system.  No one mentioned anything, but even SMB/NFS shares mounted with UD would have a recycle bin.  Not a great way to do things.

Link to post

I put a link to the previous version of the plugin on the OP that can be used to manually install the old version.

Tried using the link from the OP

plugin: installing: https://github.com/dlandon/recycle.bin/raw/master/recycle.bin.6.1.plg
plugin: downloading https://github.com/dlandon/recycle.bin/raw/master/recycle.bin.6.1.plg
plugin: downloading: https://github.com/dlandon/recycle.bin/raw/master/recycle.bin.6.1.plg ... failed (Invalid URL / Server error response)
plugin: wget: https://github.com/dlandon/recycle.bin/raw/master/recycle.bin.6.1.plg download failure (Invalid URL / Server error response)

Link to post

I put a link to the previous version of the plugin on the OP that can be used to manually install the old version.

Tried using the link from the OP

plugin: installing: https://github.com/dlandon/recycle.bin/raw/master/recycle.bin.6.1.plg
plugin: downloading https://github.com/dlandon/recycle.bin/raw/master/recycle.bin.6.1.plg
plugin: downloading: https://github.com/dlandon/recycle.bin/raw/master/recycle.bin.6.1.plg ... failed (Invalid URL / Server error response)
plugin: wget: https://github.com/dlandon/recycle.bin/raw/master/recycle.bin.6.1.plg download failure (Invalid URL / Server error response)

 

Let me check it.

Link to post

I put a link to the previous version of the plugin on the OP that can be used to manually install the old version.

Tried using the link from the OP

plugin: installing: https://github.com/dlandon/recycle.bin/raw/master/recycle.bin.6.1.plg
plugin: downloading https://github.com/dlandon/recycle.bin/raw/master/recycle.bin.6.1.plg
plugin: downloading: https://github.com/dlandon/recycle.bin/raw/master/recycle.bin.6.1.plg ... failed (Invalid URL / Server error response)
plugin: wget: https://github.com/dlandon/recycle.bin/raw/master/recycle.bin.6.1.plg download failure (Invalid URL / Server error response)

 

Try now.  I put it in the wrong repository.

Link to post

This sucker saved my bacon many times.  With the new capability LT has given me, it is now much better because I can do a per share recycle bin.  The old way of doing it globally meant the recycle bin was on for every share in the system.  No one mentioned anything, but even SMB/NFS shares mounted with UD would have a recycle bin.  Not a great way to do things.

 

Awesome!  I can turn this off on the share used for my Wife's Apple backups :)

 

A little donation should be in your tip jar ;)

Link to post

There is a new version of the recycle bin - 2017.02.06a.  The changes are:

- Rearranged the tabs, renamed tabs, and added better icons.

- When the recycle bin is purged, any empty .Recycle.Bin folders will be removed.

- When the recycle bin is emptied, all .Recycle.Bin folders will be removed.

 

When you browse the recycle bin from the webgui, you will only see shares with files in the share .Recycle.Bin.

 

The "Shares" tab is where you can see the shares included in the recycle bins and the size of the trash on each share.

 

A few versions back I enabled a recycle bin parameter that blocks any files with zero length.  I've seen where Windows will leave a file in the recycle bin with a zero length.  A zero length file has no value so they are blocked from the recycle bin.  This may have been a point of confusion in the past where users think their files are not being stored on a share, but put into the recycle bin.

Link to post

This no longer seems to be moving things to the recycle bin. I have upgraded to 6.3, uninstalled the plugin, removed all .Recycle.Bin folders and reinstalled it from community applications. However when I create a text file and delete it it does not create a .Recycle.Bin folder.

 

Is there any other information I can provide? I'd love to get this working again.

 

Thanks!

Link to post

This no longer seems to be moving things to the recycle bin. I have upgraded to 6.3, uninstalled the plugin, removed all .Recycle.Bin folders and reinstalled it from community applications. However when I create a text file and delete it it does not create a .Recycle.Bin folder.

 

Is there any other information I can provide? I'd love to get this working again.

 

Thanks!

 

I need more information.  You have the recycle bin enabled?  You are doing the delete through a smb share?

 

Check the shares tab of the recycle bin to be sure the share is enabled.  Look at the deleted files log and see if it has logged the deleted file.

 

A zero length file will not be put in the recycle bin.  You did enter something into the text file?

Link to post

This no longer seems to be moving things to the recycle bin. I have upgraded to 6.3, uninstalled the plugin, removed all .Recycle.Bin folders and reinstalled it from community applications. However when I create a text file and delete it it does not create a .Recycle.Bin folder.

 

Is there any other information I can provide? I'd love to get this working again.

 

Thanks!

 

I need more information.  You have the recycle bin enabled?  You are doing the delete through a smb share?

 

Check the shares tab of the recycle bin to be sure the share is enabled.  Look at the deleted files log and see if it has logged the deleted file.

 

A zero length file will not be put in the recycle bin.  You did enter something into the text file?

 

I do have the recycle bin enabled. I am using SMB. All my shares are listed under the Shares portion of that page. I have tested with a text file with text in it as well as duplicating one of the other larger files. Deleting these files does not create the recycle folder. The deleted files log on the recycle bin settings page is blank, I do have logging enabled.

Link to post

This no longer seems to be moving things to the recycle bin. I have upgraded to 6.3, uninstalled the plugin, removed all .Recycle.Bin folders and reinstalled it from community applications. However when I create a text file and delete it it does not create a .Recycle.Bin folder.

 

Is there any other information I can provide? I'd love to get this working again.

 

Thanks!

 

I need more information.  You have the recycle bin enabled?  You are doing the delete through a smb share?

 

Check the shares tab of the recycle bin to be sure the share is enabled.  Look at the deleted files log and see if it has logged the deleted file.

 

A zero length file will not be put in the recycle bin.  You did enter something into the text file?

 

I do have the recycle bin enabled. I am using SMB. All my shares are listed under the Shares portion of that page. I have tested with a text file with text in it as well as duplicating one of the other larger files. Deleting these files does not create the recycle folder. The deleted files log on the recycle bin settings page is blank, I do have logging enabled.

 

Copy and post the /etc/samba/smb-shares.conf file.  Tell me which share you are trying to delete the file from.

 

Have you tried another share?

Link to post

This no longer seems to be moving things to the recycle bin. I have upgraded to 6.3, uninstalled the plugin, removed all .Recycle.Bin folders and reinstalled it from community applications. However when I create a text file and delete it it does not create a .Recycle.Bin folder.

 

Is there any other information I can provide? I'd love to get this working again.

 

Thanks!

 

I need more information.  You have the recycle bin enabled?  You are doing the delete through a smb share?

 

Check the shares tab of the recycle bin to be sure the share is enabled.  Look at the deleted files log and see if it has logged the deleted file.

 

A zero length file will not be put in the recycle bin.  You did enter something into the text file?

 

I do have the recycle bin enabled. I am using SMB. All my shares are listed under the Shares portion of that page. I have tested with a text file with text in it as well as duplicating one of the other larger files. Deleting these files does not create the recycle folder. The deleted files log on the recycle bin settings page is blank, I do have logging enabled.

 

Copy and post the /etc/samba/smb-shares.conf file.  Tell me which share you are trying to delete the file from.

 

Have you tried another share?

 

Here is the requested file http://pastebin.com/wJLkj5ak

 

I have tried on the TV - Shows share and the Downloads share.

Link to post
  • dlandon changed the title to Recycle Bin (vfs recycle) for SMB Shares

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.