Recycle Bin (vfs recycle) for SMB Shares


dlandon

794 posts in this topic Last Reply

Recommended Posts

Since I updated to 6.2.1 I'm getting error messages when I boot.

/usr/local/emhttp/plugins/recycle.bin/scripts/rc.recycle.bin: line 26: [: =: unary operator expected.

 

The error is repeated three times for lines 26, 29, & 32.

 

I'm not sure if recycle bin is currently working or not.  The plugin is dated 2016.10.07

 

Thanks.

 

Link to post
  • Replies 793
  • Created
  • Last Reply

Top Posters In This Topic

Top Posters In This Topic

Popular Posts

This is a plugin that will create a per share .Recycle.Bin folder on each smb share for files deleted on that share.  Built into samba is a module called "vfs recycle" that handles the deletion of fil

Shares were not displaying when "Log Deleted Files" was set to "No".  This has been fixed in the latest version.

No longer true.  I'm releasing a new version that will not show any remote mounted shares and the local recycle bin will not remove any files from the remote share recycle bins.  Only the local server

Posted Images

Since I updated to 6.2.1 I'm getting error messages when I boot.

/usr/local/emhttp/plugins/recycle.bin/scripts/rc.recycle.bin: line 26: [: =: unary operator expected.

 

The error is repeated three times for lines 26, 29, & 32.

 

I'm not sure if recycle bin is currently working or not.  The plugin is dated 2016.10.07

 

Thanks.

 

Fixed in latest release.

Link to post

Since I updated to 6.2.1 I'm getting error messages when I boot.

/usr/local/emhttp/plugins/recycle.bin/scripts/rc.recycle.bin: line 26: [: =: unary operator expected.

The error is repeated three times for lines 26, 29, & 32.

I'm not sure if recycle bin is currently working or not.  The plugin is dated 2016.10.07

Thanks.

 

Fixed in latest release.

Thanks.  I just received the update.  I'll reboot in the morning.

 

Link to post
  • 3 weeks later...

It has to do with how the plugin is scripted to detect the emhttp docroot:

 

<!--
DOCROOT script.
-->
<FILE Name="/tmp/&name;/docroot" Mode="0770">
<INLINE>
#!/bin/bash
DOCROOT=`grep -Po '^chdir = \K.*' /etc/php-fpm.d/www.conf`
if [ -z ${DOCROOT} ];then
DOCROOT="/usr/local/emhttp"
fi

echo ${DOCROOT}
</INLINE>
</FILE>

Link to post

It's a harmless message and occurs from the www.conf file not found in previous versions.  I'll update the plugin to not display that message.

 

This change involving the docroot is in anticipation of a change from emhttp.  The path to the webgui wouldl change and the plugin will handle emhttp and a newer webgui path by looking it up.  If the www.conf file is not found, the docroot defaults to /usr/local/emhttp for backwards compatibility.

Link to post

It's a harmless message and occurs from the www.conf file not found in previous versions.  I'll update the plugin to not display that message.

 

This change involving the docroot is in anticipation of a change from emhttp.  The path to the webgui wouldl change and the plugin will handle emhttp and a newer webgui path by looking it up.  If the www.conf file is not found, the docroot defaults to /usr/local/emhttp for backwards compatibility.

I thought Bonienl reverted those changes.

 

Sent from my LG-D852 using Tapatalk

 

 

Link to post

It's a harmless message and occurs from the www.conf file not found in previous versions.  I'll update the plugin to not display that message.

 

This change involving the docroot is in anticipation of a change from emhttp.  The path to the webgui wouldl change and the plugin will handle emhttp and a newer webgui path by looking it up.  If the www.conf file is not found, the docroot defaults to /usr/local/emhttp for backwards compatibility.

I thought Bonienl reverted those changes.

 

Sent from my LG-D852 using Tapatalk

 

If he did, I missed the memo on that.

Link to post

It's a harmless message and occurs from the www.conf file not found in previous versions.  I'll update the plugin to not display that message.

 

This change involving the docroot is in anticipation of a change from emhttp.  The path to the webgui wouldl change and the plugin will handle emhttp and a newer webgui path by looking it up.  If the www.conf file is not found, the docroot defaults to /usr/local/emhttp for backwards compatibility.

I thought Bonienl reverted those changes.

 

Sent from my LG-D852 using Tapatalk

 

If he did, I missed the memo on that.

Mobile so pita for me to find the post but IIRC he changed it, then my plugins would wind up crashing so he reverted them

 

Sent from my LG-D852 using Tapatalk

 

 

Link to post
  • 1 month later...

This has stopped working for me recently - files deleted no longer go into the bin. May have coincided with rc6 installation.  What logs do you need to debug?

 

The vfs_recycle function of samba is not working in rc6.  I'll post a defect report.

Link to post
  • 3 weeks later...
  • 3 weeks later...

Hello,

For some reasons all the files I copy to the server end up in the Recycle Bin. Here is the example from the Recycle Bin log of the file I just copied, it wasn't deleted ( I replaced the original folder/file names):

 

[2017/01/16 12:05:06.043293,  0] ../source3/modules/vfs_extd_audit.c:262(audit_unlink)

  vfs_extd_audit: unlink TV Series/<folder name>/<file name>.mkv 

 

I see the same file when I browse the share.

 

root@Tower:/mnt/user/Movies/.Recycle.Bin/TV Series/<folder name>/<folder name># ls -all <file name>.mkv

-rw-rw-rw- 1 <user name> users 1739921277 Jan 16 12:05 <file name>.mkv

 

 

Not sure if I'm missing something. Why all the files that haven't been deleted, but just copied over show up in the Recycle Bin ?

Link to post
  • 2 weeks later...

Hello,

For some reasons all the files I copy to the server end up in the Recycle Bin. Here is the example from the Recycle Bin log of the file I just copied, it wasn't deleted ( I replaced the original folder/file names):

 

[2017/01/16 12:05:06.043293,  0] ../source3/modules/vfs_extd_audit.c:262(audit_unlink)

  vfs_extd_audit: unlink TV Series/<folder name>/<file name>.mkv 

 

I see the same file when I browse the share.

 

root@Tower:/mnt/user/Movies/.Recycle.Bin/TV Series/<folder name>/<folder name># ls -all <file name>.mkv

-rw-rw-rw- 1 <user name> users 1739921277 Jan 16 12:05 <file name>.mkv

 

 

Not sure if I'm missing something. Why all the files that haven't been deleted, but just copied over show up in the Recycle Bin ?

 

I have the exact same problem, alot of stuff has been put in the recycle bin folder, it seems like all files goes to the recycle bin folder even on the cache drive. And then is moved to the wrong place on my shares.

Link to post

Hello,

For some reasons all the files I copy to the server end up in the Recycle Bin. Here is the example from the Recycle Bin log of the file I just copied, it wasn't deleted ( I replaced the original folder/file names):

 

[2017/01/16 12:05:06.043293,  0] ../source3/modules/vfs_extd_audit.c:262(audit_unlink)

  vfs_extd_audit: unlink TV Series/<folder name>/<file name>.mkv 

 

I see the same file when I browse the share.

 

root@Tower:/mnt/user/Movies/.Recycle.Bin/TV Series/<folder name>/<folder name># ls -all <file name>.mkv

-rw-rw-rw- 1 <user name> users 1739921277 Jan 16 12:05 <file name>.mkv

 

 

Not sure if I'm missing something. Why all the files that haven't been deleted, but just copied over show up in the Recycle Bin ?

 

I have the exact same problem, alot of stuff has been put in the recycle bin folder, it seems like all files goes to the recycle bin folder even on the cache drive. And then is moved to the wrong place on my shares.

 

The recycle bin plugin has no control over the files that are deleted.  The recycle bin plugin only enables the vfs_recycle option in samba.  You may find that windows is creating temporary files that get deleted and end up in the recycle bin.  You will probably see that the files in the recycle bin have the same name, but a different extension.

Link to post

The existing recycle bin does not work on the 6.3 final release.  I have updated it for 6.3 final, but it will not be backwards compatible because of changes in 6.3 to accommodate other features that broke the recycle bin.  This required the recycle bin to be rewritten.  The previous version will be deprecated fail to update, so it will not be removed.  It will continue to work without any issues.

 

The advantages of the new recycle bin are:

- True per share recycle bins.  You can specify shares to exclude.

- You can optionally exclude all UD devices, or on a per UD share.

 

I will complete testing this weekend and release an updated version.

Link to post

Should I delete the current version of recyclebin before upgrading to unRAID 6.3?

 

Yes.  Remove the old recycle bin and then use CA to get the latest version.  You can do this either before or do this after the update.

Link to post

Should I delete the current version of recyclebin before upgrading to unRAID 6.3?

 

Yes.  Remove the old recycle bin and then use CA to get the latest version.  You can do this either before or after the update.

Do it after upgrading.  It won't be listed within CA until after the upgrade to 6.3
Link to post

The existing recycle bin does not work on the 6.3 final release.  I have updated it for 6.3 final, but it will not be backwards compatible because of changes in 6.3 to accommodate other features that broke the recycle bin.  This required the recycle bin to be rewritten.  The previous version will be deprecated.

 

Dan, respectfully, please don't terminate the previous version, there will be users who stay with older versions, that's just the way it is, probably always will be.  Just a note about the term 'deprecate', when you say something is deprecated, you aren't saying it's terminated, you are saying it's still available and completely usable, but that there's another option that is now preferred over it.  For example, Microsoft would say that Windows 7 is deprecated in favor of Windows 10.  Many users would disagree, and continue using it.

 

I would prefer that auto update be turned off for the previous version, so that the Recycle Bin still works for all users, no matter what version they decide to use.

Link to post

The existing recycle bin does not work on the 6.3 final release.  I have updated it for 6.3 final, but it will not be backwards compatible because of changes in 6.3 to accommodate other features that broke the recycle bin.  This required the recycle bin to be rewritten.  The previous version will be deprecated.

 

Dan, respectfully, please don't terminate the previous version, there will be users who stay with older versions, that's just the way it is, probably always will be.  Just a note about the term 'deprecate', when you say something is deprecated, you aren't saying it's terminated, you are saying it's still available and completely usable, but that there's another option that is now preferred over it.  For example, Microsoft would say that Windows 7 is deprecated in favor of Windows 10.  Many users would disagree, and continue using it.

 

I would prefer that auto update be turned off for the previous version, so that the Recycle Bin still works for all users, no matter what version they decide to use.

Better way is a completely separate plg file for the new version.  With the appropriate template settings, CA will only display the one that works on the user's system, and in the case of a later upgrade, FCP will catch if the incorrect version is installed
Link to post

If a user of an older version tries to upgrade, the plugin will fail with a version incompatibility message and leave the old version in place.  I don't see any issue here.  A new user should use 6.3 and not an older version so a new install of the plugin will be the latest version.

 

You will notice that LT has removed all versions of the OS but version 6.3 from the downloads available on the LimeTech website.  Tom is fairly insistent that due to security issues, that users upgrade to 6.3.

 

PREVIOUS unRAID OS RELEASES ARE VULNERABLE TO CSRF/XSS ATTACK AND WE STRONGLY RECOMMEND ALL USERS UPGRADE TO THIS RELEASE

 

This is why I decided to drop backwards compatibility.  I do not want to support two versions in any way.  It is not necessary and it's time to move on.  I've already spent MANY hours getting the new version up and running.

 

If someone feels that I absolutely have to do this or they'll explode, how about a contribution?

Link to post
  • dlandon changed the title to Recycle Bin (vfs recycle) for SMB Shares

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.