[Plugin] ControlR

[jbrodriguez]

3 hours ago, T.Wilke said:

Hi everyone!

I‘m just wondering, where I can set the user permissions without the UI? The app shows me the server, but there are no dockers listed and the VM are just shown without controls to operate. Could you please help me with that? Thank you!

hi, currently the only supported login is root, are you connecting as root ?

[T.Wilke]

Yes! I‘m connected as Root.


Gesendet von iPhone mit Tapatalk

[jbrodriguez]

that's strange then, never heard of this issue before, would you be willing to create a troubleshooting package as described here https://github.com/jbrodriguez/controlr-support ? 

i need to make some changes first, because it currently doesn't work (i haven't updated it in a while)

[T.Wilke]

Shure! Drop me a line, whenever you are ready with your update. Thank you!


Gesendet von iPhone mit Tapatalk

[jbrodriguez]

1 hour ago, T.Wilke said:

Shure! Drop me a line, whenever you are ready with your update. Thank you!

the script is updated, feel free to use it at your convenience 

[T.Wilke]

I‘ve send you an email with the results some weeks ago. Did you find any solutions for my problem, yet?


Gesendet von iPhone mit Tapatalk

[jbrodriguez]

4 minutes ago, T.Wilke said:

I‘ve send you an email with the results some weeks ago. Did you find any solutions for my problem, yet?


Gesendet von iPhone mit Tapatalk

hi ! i didn't receive the email 🤔, (i checked in spam too) can you try sending it again to [email protected] ?

[T.Wilke]

Hi! That was exactly the address I used on 7th of February for the files. I’ve resend the email now and hope, that it will reach you this time…


Gesendet von iPhone mit Tapatalk

[jbrodriguez]

@T.Wilkei got the email and found the issue, turns out that you changed one of the dockers to use a custom icon, and causes troubles for the app
 

i will publish an update in an upcoming version (i have one update currently under review with apple), it will show your dockers, however it won't display that particular icon, since the path is not reachable from outside the server. 

 

i don't see a generic way to support custom icons at the moment, but if you want to display the icon it should be on a path that is reachable from "outside" the server: for example, the docker icons are stored in '/state/plugins/dynamix.docker.manager/images/' 

 

to summarize, i have a fix that will be available soon so that you can see the dockers, however the icon won't be displayed

[T.Wilke]

Wow! Great! Thank you for your really fast analysis! That sounds really good for me. I think custom icons at VMs cause the same problems: I do not see the controls at VMs as well, because I have one VM with a custom icon…


Gesendet von iPhone mit Tapatalk

[jbrodriguez]

there's another issue with the vm controls (and dockers potentially), this will be fixed in 6.2.1

[T.Wilke]

Wow! Really great service! Thank you so much!


Gesendet von iPhone mit Tapatalk

[T.Wilke]

Thank you so much for the New Version 6.2.2 of your Plugin! I can confirm, that this one is working with unraid 6.12.8 and custom icons with dockers and VMs. Everything ist working perfectly! Great!


Gesendet von iPhone mit Tapatalk

[corgan]

Hello,

 

if I activate the "Provide UPS status" option in the plugin settings, the plugin will not start. Status "Stopped".

 

 

If I deactivate the option, everything works fine.

I would assume the reason is, that I use the "Network UPS Tools (NUT) for UNRAID" Plugin and not the build-in "UPS Settings". Any change to get the Infos from this plugin integrated?

[jbrodriguez]

16 hours ago, corgan said:

Hello,

 

if I activate the "Provide UPS status" option in the plugin settings, the plugin will not start. Status "Stopped".

 

 

If I deactivate the option, everything works fine.

I would assume the reason is, that I use the "Network UPS Tools (NUT) for UNRAID" Plugin and not the build-in "UPS Settings". Any change to get the Infos from this plugin integrated?

hi, it should work even with the nut plugin, but perhaps something changed "recently"

i'll look into it

[Rysz]

22 hours ago, jbrodriguez said:

hi, it should work even with the nut plugin, but perhaps something changed "recently"

i'll look into it

Hello!

 

I've had to change around some paths in the NUT plugin to ensure future version compatibility for UNRAID 6.13+ .... and that's what's likely causing the trouble here - sorry about the inconvenience for your plugin! 😞 

 

const nutConfig string = "/boot/config/plugins/nut/nut.cfg"

 

has changed to

 

const nutConfig string = "/boot/config/plugins/nut-dw/nut-dw.cfg"

 

This is the complete migration process: https://pastebin.com/YkCC1Vde

 

But it's probably best to look for the configuration file in both locations because people who have not migrated to the newer NUT version will have the configuration file in the old (first) location, and those who migrated to the newer version of NUT will have it in the new (second) location (and the old location renamed to 'nut-old').

 

Send me a PM anytime if you need any more information regarding NUT.

 

Edited March 18 by Rysz

[jbrodriguez]

9 hours ago, Rysz said:

I've had to change around some paths in the NUT plugin to ensure future version compatibility for UNRAID 6.13+

oh cool, that makes sense, i'll check for those changes in my code, thanks for pointing this out !

[jbrodriguez]

IMPORTANT NOTICE

 

if you're receiving the following error for the controlr plugin

please uninstall the plugin / then reinstall

i had to change the location of the plg file and it causes this issue

[Rysz]

Is there any reason the program is closed source now? It seems there's been no update to it for a long time, now suddenly there's a new release with a changed PLG location and all the source code was removed from the GitHub repository. The newly released package contains a compiled binary but no source code to go with it. It's one thing to not include source code with binaries where the source code is publicly available (e.g. rclone), but with a self-coded project I'm pretty sure this is against Community Applications rules and in light of recent developments with the XZ Utils backdoor it really makes me nervous (probably unwarranted). I'm sure there's a solid reason and I don't want to throw around accusations at all, but better to get out in front of this. 🙂 

 

It's just seems a bit weird that there was source code before and now it's suddenly removed before a new release is put out after a longer hiatus, the PLG location suddenly changing too... I mean why go to such lengths, inconveniencing the users with a PLG location change, to remove source code?

 

 

 

https://github.com/jbrodriguez/controlr

https://github.com/jbrodriguez/controlr/pull/36

https://github.com/jbrodriguez/controlr/commit/154360d41dac9591d8064656f8dffc97337fda1e

 

@SpencerJ @Squid

 

Edited April 13 by Rysz

[jbrodriguez]

hey, that's a good question, i hadn't looked at it this way

 

this plugin always had a closed source component, as it's mostly an extension of the mobile app

it provides an api to some functionalities not readily available from unraid

 

initially i implemented a role based access for the app (different users had different permissions), but this became too cumbersome with unraid's "one user (root)" implementation, so i dropped that

the other "ui" functionality was to calculate the qrcode to add a server, but it was just too much to have a full ui just for that

so, i moved the qrcode to the unraid plugin page

 

i recently found a bug related to the qrcode data, it was always returning http protocol, even if the server was set to https, so i fixed the bug and decided to remove all the dead code and leave only the api services needed for the mobile app (which was always closed source)

 

however i really hope to deprecate this plugin once unraid makes it's api publicly available

 

P.S.: not sure about community app rules 🤷‍♂️, however there are some other plugins in the community apps that are not open source (tailscale comes to mind)

 

[Rysz]

6 minutes ago, jbrodriguez said:

hey, that's a good question, i hadn't looked at it this way

 

this plugin always had a closed source component, as it's mostly an extension of the mobile app

it provides an api to some functionalities not readily available from unraid

 

initially i implemented a role based access for the app (different users had different permissions), but this became too cumbersome with unraid's "one user (root)" implementation, so i dropped that

the other "ui" functionality was to calculate the qrcode to add a server, but it was just too much to have a full ui just for that

so, i moved the qrcode to the unraid plugin page

 

i recently found a bug related to the qrcode data, it was always returning http protocol, even if the server was set to https, so i fixed the bug and decided to remove all the dead code and leave only the api services needed for the mobile app (which was always closed source)

 

however i really hope to deprecate this plugin once unraid makes it's api publicly available

 

P.S.: not sure about community app rules 🤷‍♂️, however there are some other plugins in the community apps that are not open source (tailscale comes to mind)

 

 

Thanks for getting back to me so quick, makes absolute sense from your perspective and you're right about other plugins, of course, it probably boils down to moderation discretion and where it makes sense and doesn't (which it seems to do in your case). Please also don't get me wrong for pointing this out. I just think it's good to talk about such things especially at this point in time where people are on high alert with everything. I'm probably also a bit more paranoid after the whole XZ situation and one too many security meetings at work.  

[jbrodriguez]

2 hours ago, Rysz said:

Please also don't get me wrong for pointing this out. I just think it's good to talk about such things

not at all, xz did make some waves 😮

[Squid]

7 hours ago, Rysz said:

moderation discretion

Every plugin,  no exceptions, are checked for security issues.  This doesn't mean that there isn't going to be security flaws caused by libraries utilized, but you do know that any random plugin is not going to go ahead and outright delete your media etc.

 

Every single plugin available via Apps gets installed on my production server, with no exceptions, and a code audit is done on what is actually present instead of what may be showing on GitHub.  Every single update to every plugin I am notified about (within 2 hours), and with plugins which are not maintained by a contractor of Limetech is then code audited again.  Every update.  And with only a few exceptions, this happens on an actual production server not on a test server.

 

If something ever fails the checks, then everything else gets dropped (including the 9-5 job) to handle the issue.  Whether that means simply getting the application out of apps temporarily and asking the maintainer / author "WTF? You can't do this", or notifying everyone with it installed via FCP about any issue, or preventing the Auto Update plugin from installing any update to the plugin, or even taken more drastic measures, provisions are in place to protect the user..

 

Closed source applications, whether they are plugins or containers, may be frowned upon, but are not necessarily disallowed.  With plugins, the standard for open-source vs closed-source is more strict, but it is not 100% a requirement that only open source be present. 

[EDACerton]

On 4/13/2024 at 9:58 AM, jbrodriguez said:

P.S.: not sure about community app rules 🤷‍♂️, however there are some other plugins in the community apps that are not open source (tailscale comes to mind)

 

FYI -- the Tailscale comment here is not accurate, all components are open source:

• unraid-tailscale (main plugin): https://github.com/dkaser/unraid-tailscale
• unraid-tailscale-utils (script package): https://github.com/dkaser/unraid-tailscale-utils
• unraid-plugin-diagnostics (custom diagnostics generator): https://github.com/dkaser/unraid-plugin-diagnostics
• tailscale: https://github.com/tailscale/tailscale

[jbrodriguez]

sorry to have brought you in @EDACerton🙏, i was really referring to the underlying app, tailscale itself, which isn't fully open source (https://tailscale.com/opensource#faqs)