dorgan Posted October 7, 2018 Author Share Posted October 7, 2018 If you must store within appdata, then your best bet would be the default appdata location that can be found within /boot/config/docker.cfgDefinitely will update to this. What’s being stored besides the cfg is the actual data for vnstat, as keeping it in the default location was causing it to be deleted on reboot. Quote Link to comment
dorgan Posted October 7, 2018 Author Share Posted October 7, 2018 I have the 9/29/2018 version running and then did the 2018.10.06c update. Not the vnstat is no longer running. I did go to the plugin settings and tried to click "Start". No luck.I think it’s because of the hard coded path. I’ll get a release out in the next day or so. Quote Link to comment
dorgan Posted October 7, 2018 Author Share Posted October 7, 2018 4 hours ago, Wayne66 said: I have the 9/29/2018 version running and then did the 2018.10.06c update. Not the vnstat is no longer running. I did go to the plugin settings and tried to click "Start". No luck. Version 2018.10.07 has been released and will use docker appdata path. Please let me know if this gets you back into a working condition. Quote Link to comment
Squid Posted October 7, 2018 Share Posted October 7, 2018 Allows to start / stop now, but it's not populating the page with anything other than 2 "broken pictures". (let it sit for awhile). the appdata does have *something* in the various interfaces (docker, etc) there. Beyond that, you might want to consider silencing this from being logged: Oct 7 18:02:10 ServerA vnstatd[25705]: Traffic rate for "vnet1" higher than set maximum 10 Mbit (30->42, r0 t117), syncing. With a line logged every 30seconds, the log will fairly quickly fill up. Quote Link to comment
dorgan Posted October 7, 2018 Author Share Posted October 7, 2018 Allows to start / stop now, but it's not populating the page with anything other than 2 "broken pictures". (let it sit for awhile). the appdata does have *something* in the various interfaces (docker, etc) there. Beyond that, you might want to consider silencing this from being logged:Oct 7 18:02:10 ServerA vnstatd[25705]: Traffic rate for "vnet1" higher than set maximum 10 Mbit (30->42, r0 t117), syncing. With a line logged every 30seconds, the log will fairly quickly fill up. Takes time to populate, also go into settings and select the interfaces you want to track. I’ll work on adding some messaging and a cleaner response for that initial time. I’ll look into the log settings and see what can be done there as well. Quote Link to comment
dorgan Posted October 7, 2018 Author Share Posted October 7, 2018 @Squidactually it seems the MaxBandwidth setting was the possible cause of no data being populated. Version 2018.10.07a has been released and adjusts this setting. Quote Link to comment
CHBMB Posted October 7, 2018 Share Posted October 7, 2018 Nice work, just installed this and it's cool. I got a couple of suggestions though. 1. Probably need to make it clearer that a prerequisite is having Dynamix System Statistics installed, or perhaps install it as part of your own install routine. 2. I don't use /mnt/user/appdata/ on my array. Instead I use a SSD mounted via unassigned devices, so by installing your plugin I've now got an appdata share on my array of which the only subfolder is vnstat, so I think this should be either configurable by the user, or even grab their current appdata location with something like this. cat /boot/config/docker.cfg | grep DOCKER_APP_CONFIG_PATH | cut -d'"' -f 2 Quote Link to comment
dorgan Posted October 7, 2018 Author Share Posted October 7, 2018 Nice work, just installed this and it's cool. I got a couple of suggestions though. 1. Probably need to make it clearer that a prerequisite is having Dynamix System Statistics installed, or perhaps install it as part of your own install routine. 2. I don't use /mnt/user/appdata/ on my array. Instead I use a SSD mounted via unassigned devices, so by installing your plugin I've now got an appdata share on my array of which the only subfolder is vnstat, so I think this should be either configurable by the user, or even grab their current appdata location with something like this.cat /boot/config/docker.cfg | grep DOCKER_APP_CONFIG_PATH | cut -d'"' -f 2 I am using DOCKER_APP_CONFIG_PATH in the versions I released today.As for the other plugin, I didn’t make a requirement or anything. What happens when that’s not installed? Quote Link to comment
CHBMB Posted October 7, 2018 Share Posted October 7, 2018 (edited) 5 minutes ago, dorgan said: I am using DOCKER_APP_CONFIG_PATH in the versions I released today. As for the other plugin, I didn’t make a requirement or anything. What happens when that’s not installed? Didn't realise the first point, but now I looked I think you missed a trailing slash buddy.... https://github.com/dorgan/Unraid-networkstats/blob/master/networkstats.plg#L147 On the second point, If Dynamix System Statistics isn't installed then there's no "STATS" page. Edited October 7, 2018 by CHBMB Quote Link to comment
dorgan Posted October 7, 2018 Author Share Posted October 7, 2018 2 minutes ago, CHBMB said: Didn't realise the first point, but now I looked I think you missed a trailing slash buddy.... does vnstat exist inside appdata, or is putting everything inside of appdatavnstat? Quote Link to comment
Squid Posted October 7, 2018 Share Posted October 7, 2018 On the second point, If Dynamix System Statistics isn't installed then there's no "STATS" page.Dorgan just needs to include the stats.page file from the dynamix plugin so that it'll work without stats being installed (it's just a header page file that creates the tab)Sent from my LG-D852 using Tapatalk Quote Link to comment
CHBMB Posted October 7, 2018 Share Posted October 7, 2018 (edited) 7 minutes ago, dorgan said: does vnstat exist inside appdata, or is putting everything inside of appdatavnstat? OK. There's nothing inside appdata at all. appdatavnstat has an empty subfolder with nothing in it. I deleted /mnt/user/appdata/ and also /appdatavnstat and removed then reinstalled your plugin and it's recreated the /mnt/user/appdata/vnstat/ folder. I can see in your plugin you're using a variable like I highlighted in the link above, but I might be mistaken, I can't see where the variable is defined during the plugin install. root@server:/# ls -la /mnt/user/appdata/ total 4 drwxrwxr-x 1 root root 19 Oct 8 00:25 ./ drwxrwxrwx 1 nobody users 4096 Oct 8 00:25 ../ drwxrwxr-x 1 root root 23 Oct 8 00:25 vnstat/ Edited October 7, 2018 by CHBMB Quote Link to comment
dorgan Posted October 7, 2018 Author Share Posted October 7, 2018 1 minute ago, CHBMB said: ... it's recreated the /mnt/user/appdata/vnstat/ ... What is your DOCKER_APP_CONFIG_PATH set to? Quote Link to comment
dorgan Posted October 7, 2018 Author Share Posted October 7, 2018 4 minutes ago, dorgan said: What is your DOCKER_APP_CONFIG_PATH set to? OK founs where it was creating the incorrect path. Quote Link to comment
CHBMB Posted October 7, 2018 Share Posted October 7, 2018 1 minute ago, dorgan said: What is your DOCKER_APP_CONFIG_PATH set to? That's kind of immaterial, as ! = /mnt/user/appdata/ but as you asked. root@server:/# cat /boot/config/docker.cfg | grep DOCKER_APP_CONFIG_PATH | cut -d'"' -f 2 /mnt/disks/virtualisation/appdata Quote Link to comment
CHBMB Posted October 7, 2018 Share Posted October 7, 2018 I think if you add the / to line 147 and define the DOCKER_APP_CONFIG_PATH variable somewhere you'll be good.... https://github.com/dorgan/Unraid-networkstats/blob/master/networkstats.plg#L146-L147 Quote Link to comment
dorgan Posted October 7, 2018 Author Share Posted October 7, 2018 Just now, CHBMB said: I think if you add the / to line 147 and define the DOCKER_APP_CONFIG_PATH variable somewhere you'll be good.... https://github.com/dorgan/Unraid-networkstats/blob/master/networkstats.plg#L146-L147 I've found a couple issues. Pushing a new release shortly that will fix all of this. Quote Link to comment
dorgan Posted October 7, 2018 Author Share Posted October 7, 2018 There will be another version coming as I introduced an error in the vnstat.conf file and now I need to correct it Quote Link to comment
CHBMB Posted October 7, 2018 Share Posted October 7, 2018 1 minute ago, dorgan said: There will be another version coming as I introduced an error in the vnstat.conf file and now I need to correct it I was just about to point that out..... Quote Link to comment
CHBMB Posted October 7, 2018 Share Posted October 7, 2018 I still can't see anywhere that you're actually defining the variable for DOCKER_APP_CONFIG_PATH..... Only references I can see to it in your .plg file are in these lines here.... https://github.com/dorgan/Unraid-networkstats/blob/master/networkstats.plg#L146-L151 Quote Link to comment
dorgan Posted October 7, 2018 Author Share Posted October 7, 2018 (edited) 1 minute ago, CHBMB said: I still can't see anywhere that you're actually defining the variable for DOCKER_APP_CONFIG_PATH..... Only references I can see to it in your .plg file are in these lines here.... https://github.com/dorgan/Unraid-networkstats/blob/master/networkstats.plg#L146-L151 look at source /boot/config/docker.cfg that will bring them in as variables Edited October 7, 2018 by dorgan Quote Link to comment
CHBMB Posted October 8, 2018 Share Posted October 8, 2018 Actually you must be somewhere as now I'm getting two folders created on plugin install. /mnt/user/appdata/.... and /mnt/disks/virtualisation/appdatanetworkstats/ So there's still a trailing slash missing. Quote Link to comment
dorgan Posted October 8, 2018 Author Share Posted October 8, 2018 Just now, CHBMB said: Actually you must be somewhere as now I'm getting two folders created on plugin install. /mnt/user/appdata/.... and /mnt/disks/virtualisation/appdatanetworkstats/ So there's still a trailing slash missing. Yeah i have some sloppiness, cleaning that up now. Quote Link to comment
CHBMB Posted October 8, 2018 Share Posted October 8, 2018 Ah, my bad, missed that one. Quote Link to comment
dorgan Posted October 8, 2018 Author Share Posted October 8, 2018 Just now, CHBMB said: Ah, my bad, missed that one. hmmm my DOCKER_APP_CONFIG_PATH has a slash at the end yours doesn't. I need to account for that. Quote Link to comment
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.