Recycle Bin (vfs recycle) for SMB Shares

[Falloutman]

17 minutes ago, dlandon said:

What is your use case?

Everything across each share, including the Recycle Bin, is being backed up by my backup software. While I could exclude the folder, doing so for every new share would get tiresome. If I could relocate these files to an other share, let's say a Recycling Bin share, it would make maintenance simpler.

[dlandon]

3 minutes ago, Falloutman said:

Everything across each share, including the Recycle Bin, is being backed up by my backup software. While I could exclude the folder, doing so for every new share would get tiresome. If I could relocate these files to an other share, let's say a Recycling Bin share, it would make maintenance simpler.

It is setup to be a .Recycle.Bin per share.  That's how the Samba recycle bin works.  It currently can't be a recycle bin for all shares.  Just exclude the Recycle.Bin folders in your backups.

[aim60]

I’m running 6.11.5, and after updating the plugin to 2023.02.20, I’m still having instances of folders in the recycle bin with their files missing.  However, my usage is probably uncommon.  My apps are configured to use user shares, but interactively, I use disk shares.

 

During testing, deletes were done from a Windows client.  In all test cases, I am deleting:

  \\Servername\DiskOrPoolName\UserShare\FolderWithFile

 

If the user share resides on an array disk (they are all Use cache pool=no), the folder and file show up in the disk’s .Recyele.Bin folder as expected.

 

If the user share resides on the cache pool (they are all Use cache pool=only), the folder appears in the pool’s .Recycle.Bin without the file.

 

The strange thing is, during testing I created a new user share in the cache pool, and it is working as expected.

 

None of my other pools had previously defined user shares, and newly defined shares work ok.

 

tower7-diagnostics-20230403-1145.zip

Edited April 3, 2023 by aim60

[dlandon]

3 hours ago, aim60 said:

I’m running 6.11.5, and after updating the plugin to 2023.02.20, I’m still having instances of folders in the recycle bin with their files missing.  However, my usage is probably uncommon.  My apps are configured to use user shares, but interactively, I use disk shares.

 

During testing, deletes were done from a Windows client.  In all test cases, I am deleting:

  \\Servername\DiskOrPoolName\UserShare\FolderWithFile

 

If the user share resides on an array disk (they are all Use cache pool=no), the folder and file show up in the disk’s .Recyele.Bin folder as expected.

 

If the user share resides on the cache pool (they are all Use cache pool=only), the folder appears in the pool’s .Recycle.Bin without the file.

 

The strange thing is, during testing I created a new user share in the cache pool, and it is working as expected.

 

None of my other pools had previously defined user shares, and newly defined shares work ok.

 

Why are you deleting files on your dsk, cache, or pool device?  You should only delete files in the user shares, no matter where they are residing.  A delete of \\Servername\DiskorPoolName/UserShare\fileorfolder is not the same as \\Servername\UserShare\fileorfolder.  For best management of the recycle bin, you should only delete from \\Servername\UserShare\.  The deleted files and folders will go to the \\Servername\UserShare\.Recycle.Bin\ folder.  If you delete from the disk, cache, or a pool device, the deleted files and folders will go to the \\Servername\DiskorPoolName\.Recycle.Bin\ folder.

 

You need to turn off Disk sharing and just stick with the user shares shown when browsing the \\ServerName.

[jcofer555]

every time i empty the recycle bin it seems to do a mini smb reset or something as any encodes i have going in my vm that i run handbrake in with the loading and saving of the files coming from an smb share errors out and has to be reset.

[dlandon]

3 hours ago, jcofer555 said:

every time i empty the recycle bin it seems to do a mini smb reset or something as any encodes i have going in my vm that i run handbrake in with the loading and saving of the files coming from an smb share errors out and has to be reset.

The only time samba is restarted is when the recycle bin is stopped and started.  I'm probably going to change that.

[jcofer555]

19 hours ago, dlandon said:

The only time samba is restarted is when the recycle bin is stopped and started.  I'm probably going to change that.

any idea why it would error out my handbraking? it happens every single time i empty recycle bin.

[dlandon]

21 minutes ago, jcofer555 said:

any idea why it would error out my handbraking? it happens every single time i empty recycle bin.

All the empty recycle bin does is delete files in the .Recycle.Bin folder.  Is handbrake accessing a file that ended up in the Recyle Bin?  Install the open files plugin and see if handbrake is accessing any files moved to the Recycle Bin before you empty it.

[jcofer555]

On 4/12/2023 at 3:31 PM, dlandon said:

All the empty recycle bin does is delete files in the .Recycle.Bin folder.  Is handbrake accessing a file that ended up in the Recyle Bin?  Install the open files plugin and see if handbrake is accessing any files moved to the Recycle Bin before you empty it.

not seeing any files open by handbrake, also i tried enabling another setting and it also resets the jobs in my handbrake but other plugin changes do not have this effect so it's something specific to this recycle bin plugin

it seems to affect any vm, even my qbittorrent errors out when i change any setting or empty.

just did your update and that fixed it ty ty ty

Edited April 14, 2023 by jcofer555
additional information

[TheJavarian]

Hello dlandon,

 

I just installed the plug-in, however, it only works for Unassigned Share.

Could you take a quick look at my diagnostics data?

I also included a screenshot of the settings.

 

I really appreciate what you are doing here.

 

milkyway-diagnostics-20230425-1717.zip

[dlandon]

1 hour ago, TheJavarian said:

Hello dlandon,

 

I just installed the plug-in, however, it only works for Unassigned Share.

Could you take a quick look at my diagnostics data?

I also included a screenshot of the settings.

 

I really appreciate what you are doing here.

 

milkyway-diagnostics-20230425-1717.zip 347.65 kB · 0 downloads

Post the output of this command:

testparm -s

 

[TheJavarian]

5 hours ago, dlandon said:

Post the output of this command:

testparm -s

 

Here's the output of the command.

Thank you,

testparm.txt

[dlandon]

7 hours ago, TheJavarian said:

Here's the output of the command.

Thank you,

testparm.txt 4.99 kB · 0 downloads

The recycle bin is set up properly.  Keep in mind that a file with zero length will not be put into the recycle bin when it is deleted.

[TheJavarian]

On 4/26/2023 at 7:43 AM, dlandon said:

The recycle bin is set up properly.  Keep in mind that a file with zero length will not be put into the recycle bin when it is deleted.

Thank you dlandon,

It turned out I should have restarted my unraid box after installing the plug-in. After the restart, all working fine. Sorry for the false alarm.

[mgutt]

For those who like to disable the "Hide dot files" SMB setting:

 

 

But want to hide the Recycle Bin folder for the user, can add "veto files" to their SMB Settings > SMB Extras Config:

 

# disable access to recycle bin directory
veto files = /.Recycle.Bin

 

 

 

[dlandon]

On 5/18/2023 at 9:31 AM, mgutt said:

For those who like to disable the "Hide dot files" SMB setting:

 

 

But want to hide the Recycle Bin folder for the user, can add "veto files" to their SMB Settings > SMB Extras Config:

 

# disable access to recycle bin directory
veto files = /.Recycle.Bin

 

 

 

I've added a Recycle Bin setting to hide the .Recycle.Bin folder in the next release.

[Squirreljester]

All of my recycle folders seem to have disappeared from my folders when browsing via Windows since the last update.

I just had to reboot the server for another issue and my recycle folders are still not showing up anymore.

I've tried restarting the service itself without issue. It's showing sizes for the folders I've deleted things from.

I can view shares in Unraid via Shares and see the recycle bin folder, and I'm able to view/browse the share from Unraid GUI and see files/folders in the recycle bin.

Unraid versino 6.11.5

Recycle bin plugin version: 2023.5.20

[dlandon]

I added a setting to hide the recycle bin folders and had the default set to 'Yes', instead of 'No'.  Update and it should fix it.

[chrismitt2002]

not really sure how to put this but my recycle bin was working great and i could see it from directory opus (explorer replacement)

i had to restart in safe mode to fix something and after rebooting to normal mode the recycle bin has vanished and am unable to acess .Recycle.bin from the mapped drive nor from browsing to it from network i havnt tryed restarting unraid as of yet but did update the plug in

 

 

 

 

 

 

 

 

 

 

 

 

 

[JonathanM]

23 hours ago, chrismitt2002 said:

the recycle bin has vanished

Look at the posts above yours.

[chrismitt2002]

I rebooted my windows box and it showed up

[comet424]

i noticed my recyling bin page has error on the page 

Warning: A non-numeric value encountered in /usr/local/emhttp/plugins/dynamix/include/DefaultPageLayout.php(694) : eval()'d code on line 38
RECYCLE BIN

 

tardis-diagnostics-20230528-2139.zip

[comet424]

so i uninstalled the plugin  reinstalled   the error came back

 

i uninstalled deleted the plugin off the flash drive  and rebooted

 

reinstalled... and the error above comes back

 

and not sure if its releated to the vnc crashing i having...  not sure whats all getting affected

 

almost have to re do the entire server  or maybe try different ram i might try

[comet424]

i was able to fix the error..  apparently it didnt like the 2  recycling bins on the disk..  when i delete the .recyclin.bin    and uninstalled and reinstall the recycling bin app   the error hasnt come back

 

[dlandon]

11 minutes ago, comet424 said:

i was able to fix the error..  apparently it didnt like the 2  recycling bins on the disk..  when i delete the .recyclin.bin    and uninstalled and reinstall the recycling bin app   the error hasnt come back

 

The .Recycle.Bin is the one this plugin uses for deleted files.  I'll take a look and see if I can reproduce the error.  So far I've not been abe to reproduce the error.