[PLUGIN] Disk Location

[Quarkmax]

41 minutes ago, aerobrain said:

my Dashboard is totally blank

Yes, totally blank and unraid hangs up. I quickly uninstalled it after rebooting.

[Niklas]

44 minutes ago, aerobrain said:

Is anyone else having issues with the new version causing issues with their dashboard tab?

 

Just updated the plugin on both my servers and then my Dashboard is totally blank and clicking on that tab sometimes make the GUI hang. Removed the plug in on my second server and it returned to normal operation.

 

If there's any specific logs you may need to check just let me know (ideally with how to get those logs as it's not something I've done before).

 

Ta

Yes. Dashboard appeared frozen but just took a very long time to load.

Edited March 5 by Niklas

[Zonediver]

...the last update destroyed the whole GUI of unraid...

Not respondable anymore...

I am not amused...

Deleted this plugin and all is working again...

Strange 🤔👎

[BartyB]

Like many my dashboard is not loading with the newest update. Other tabs will load (after a long time). If I try to go into settings for this plugin. My UI goes back to snail pace. 

 

I am new to unraid. Can anyone tell me how I can roll back to the previous version? 

Edited March 5 by BartyB

[hfuhruhurr]

Same here. I updated to Version 2024.03.06 of Disk Location and the Dashboard will no longer load. The settings page of Disk Location does not load either. Removed the plugin and Dashboard works fine.

[cobalt027]

I'm having the same behavior. I didn't uninstall yet. Hoping an update fixes things.

[BartyB]

18 minutes ago, cobalt027 said:

I'm having the same behavior. I didn't uninstall yet. Hoping an update fixes things.

I uninstalled since it made the dashboard unusable. When I did it said the settings were not deleted so I am hoping once it's fixed and I reinstall everything goes back to the way it was. 

[brankko]

Same issue here. Either empty dashboard (blank page, or only header and top menu) or other pages taking like 2 minutes to load and become unresponsive. Tried deleting `/tmp/disklocation/db.lock` but it didn't help.

Removing the plugin resolved it.

Reinstalling brought the same issue again.

Will have to wait for the update.

 

P.S. I installed it on again on test server with nothing in it and got the same behaviour. Diagnostics attached.

discovery-diagnostics-20240306-1036.zip

Edited March 6 by brankko
Diagnostics added

[snowboardjoe]

Ouch, that was painful. Got to the point I could not load anything from the UI unless I knew what the exact URL was. I saw in the release notes that the multi minute delay was possible. IMHO, if there would be that much of an impact, it should not have been released that way. This was very disruptive.

 

I've removed the plugin for now until it's stable again.

Edited March 6 by snowboardjoe

[sonic6]

@FlamongOle i see many reports about you last update... but no one uploaded a Diagnostic file. Here is one:

unraid-1-diagnostics-20240306-0638.zip

[Zonediver]

Where is the developer?

Gone with the wind? 🤣

[mikeyosm]

Yes, latest version breaks the dashboard, sux!

[malaki86]

I'm here for the same reason. I did find an error that it's throwing in PHP.

 

[06-Mar-2024 06:27:07 America/New_York] PHP Fatal error:  Uncaught TypeError: array_column(): Argument #1 ($array) must be of type array, null given in /usr/local/emhttp/plugins/disklocation/pages/functions.php:600
Stack trace:
#0 /usr/local/emhttp/plugins/disklocation/pages/functions.php(600): array_column(NULL, 'serial')
#1 /usr/local/emhttp/plugins/disklocation/pages/functions.php(613): zfs_node('000000000000010...', NULL)
#2 /usr/local/emhttp/plugins/disklocation/pages/devices.php(536): zfs_disk('000000000000010...', NULL, NULL, 1)
#3 /usr/local/emhttp/plugins/dynamix/include/DefaultPageLayout.php(715) : eval()'d code(25): require_once('/usr/local/emht...')
#4 /usr/local/emhttp/plugins/dynamix/include/DefaultPageLayout.php(715): eval()
#5 /usr/local/emhttp/plugins/dynamix/template.php(82): require_once('/usr/local/emht...')
#6 {main}
  thrown in /usr/local/emhttp/plugins/disklocation/pages/functions.php on line 600

 

[losthorizon]

Hi everyone,

 

I have the same issue with this plugin. Dashboard tab doesn´t load.

[thedinz]

Yeap, bye bye to this plugin, not deaing with this.

 

Sometimes old school wins, just gonna write down the locations of the disk using acient tools know as paper and pen.

Edited March 6 by thedinz

[FlamongOle]

Update 2024.03.06c <- make sure it says "c" and NOT "b" before updating.

• Commit #294 - BUG: Check for ZFS before executing functions based on it. (reported by @malaki86)
• Commit #293 - BUG: Deactivated the database lock as it seem to have caused some serious issues. #290 will be incomplete again.

Please check if this helps the issue, I'm not home at the moment and can't test it myself. Sorry for the inconvenience etc. and so on   

 

Thanks for people who contribute and provide with proper information, wonderful to see people are using the plugin  

To some others, I would just recommend to read the license, especially §15-§17 😘 https://github.com/olehj/disklocation/blob/master/COPYING

[snowboardjoe]

I just installed 2024.03.06c on unRAID 6.12.8. The plugin is stable and working. All dashboards are loading normally. Thanks!

Edited March 6 by snowboardjoe

[FlamongOle]

5 hours ago, Zonediver said:

Where is the developer?

Gone with the wind? 🤣

Sorry, but I do have a life besides writing Unraid plugins  I'm now correcting bugs on my laptop in a hotel directly on GitHub on work travel after work.

[Miami_Martin]

Did a manual install with this link, https://raw.githubusercontent.com/olehj/disklocation/master/disklocation-master.plg

and everything is back to normal

[FlamongOle]

5 minutes ago, Miami_Martin said:

Did a manual install with this link, https://raw.githubusercontent.com/olehj/disklocation/master/disklocation-master.plg

and everything is back to normal

The "Apps" would use the same link, so no advantage over manual install in that regard in case you wonder. But both works  Thanks for reporting back!

[Zonediver]

2 hours ago, FlamongOle said:

Sorry, but I do have a life besides writing Unraid plugins  I'm now correcting bugs on my laptop in a hotel directly on GitHub on work travel after work.

...this was just a "little" joke 😉

I Know, you take care of bugs 👍👍👍

[Knuspar]

2 hours ago, FlamongOle said:

Update 2024.03.06c <- make sure it says "c" and NOT "b" before updating.

Im using CA Auto Update, not sure how one can avoid these things, unless using a delay

Thank you for the plug-in, and thanks for fixing it

[wgstarks]

2 hours ago, Knuspar said:

Im using CA Auto Update, not sure how one can avoid these things, unless using a delay

You can set a canary delay. I think mine is 72 hours.

[cobalt027]

6 hours ago, FlamongOle said:

Update 2024.03.06c <- make sure it says "c" and NOT "b" before updating.

• Commit #294 - BUG: Check for ZFS before executing functions based on it. (reported by @malaki86)
• Commit #293 - BUG: Deactivated the database lock as it seem to have caused some serious issues. #290 will be incomplete again.

Please check if this helps the issue, I'm not home at the moment and can't test it myself. Sorry for the inconvenience etc. and so on   

 

Thanks for people who contribute and provide with proper information, wonderful to see people are using the plugin  

To some others, I would just recommend to read the license, especially §15-§17 😘 https://github.com/olehj/disklocation/blob/master/COPYING

 

All fixed now, Dashboard is loading just fine! Loading from Tools just fine as well. Thank you again for all your efforts!

[malaki86]

Writing to confirm that 2024.03.06c works perfectly. Thanks for the quick fix and that the PHP log entry led you to the bug.

Just don't let it ever happen again 😁